[GitHub] [accumulo] ctubbsii opened a new pull request #2538: Improvements to loading of compression configs

[GitBox <gi...@apache.org>]

ctubbsii opened a new pull request #2538:
URL: https://github.com/apache/accumulo/pull/2538


   This follows up from the work done in #2518 to remove the use of the
   Java ServiceLoader for built-in known compression configs. Instead of
   loading all compression configs through the ServiceLoader, this change
   loads the known ones, and combines those with those discovered by the
   ServiceLoader. This prevents issues during development where the
   integration tests cannot be run inside an IDE, like Eclipse, due to the
   auto-service annotation processor not having been executed in that
   environment to make the implementing classes known to the ServiceLoader.
   Now, they are always available for integration tests.
   
   This also prevents the `@AutoService` annotation from being exposed in
   SPI classes, although it's not clear that's necessarily a problem.
   
   Additionally, this cleans up some of the previous code, that
   unnecessarily placed the supported algorithm names in a list, then
   converted it to an array, only to have it converted to a list again.
   
   For the pom, this change also sets the auto-service version in a
   property, so the multiple uses will use the same version, and explicitly
   includes the annotation processor in the maven-compiler-plugin
   configuration so it is consistent both within the errorprone profile and
   outside it.
   
   And finally, revert the version of Hadoop to 3.3.0, because 3.3.1 seems
   to be the cause of some flaky testing. In particular, it seems to cause
   unexpected EOF errors when trying to talk to data nodes, which is
   revealed by regular CountNameNodeOpsBulkIT failures, some so bad they
   seem to corrupt the XML output from failsafe, causing failsafe to be
   unable to read the result of the test. I was not able to reproduce these
   failures using 3.3.0, whereas I was seeing them regularly with 3.3.1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii merged pull request #2538: Improvements to loading of compression configs

[GitBox <gi...@apache.org>]

ctubbsii merged pull request #2538:
URL: https://github.com/apache/accumulo/pull/2538


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org