You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/02/17 04:36:10 UTC
[GitHub] [hive] dengzhhu653 commented on a change in pull request #2910: HIVE-24949: Fail to rename a partition with customized catalog
dengzhhu653 commented on a change in pull request #2910:
URL: https://github.com/apache/hive/pull/2910#discussion_r808668174
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -9768,7 +9767,8 @@ private void writeMPartitionColumnStatistics(Table table, Partition partition,
for (ColumnStatisticsObj statsObj : statsObjs) {
MPartitionColumnStatistics mStatsObj =
- StatObjectConverter.convertToMPartitionColumnStatistics(mPartition, statsDesc, statsObj, colStats.getEngine());
+ StatObjectConverter.convertToMPartitionColumnStatistics(mPartition, statsDesc, statsObj,
+ colStats.getEngine(), getDefaultCatalog(conf));
Review comment:
you are right, fix as suggested, the `MPartition` is nullable here due to https://github.com/apache/hive/blob/baf8247af78f35a68fab0756f9d571c73cdf5f96/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdateStat.java#L188-L192, fill the statsDesc with the catalog in this case: https://github.com/apache/hive/pull/2910/files#diff-f832bc7a00499f47169832b5ab5339dc879c994bfb955bd0c4b3ece6c236d9dcR186-R188
Thank you for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org