[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9311: [cache warm_up] warm_up slice with dashboard default_filters

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #9311: [cache warm_up] warm_up slice with dashboard default_filters
URL: https://github.com/apache/incubator-superset/pull/9311#discussion_r393242301
 
 

 ##########
 File path: superset/views/utils.py
 ##########
 @@ -262,3 +263,89 @@ def get_time_range_endpoints(
         return (TimeRangeEndpoint(start), TimeRangeEndpoint(end))
 
     return (TimeRangeEndpoint.INCLUSIVE, TimeRangeEndpoint.EXCLUSIVE)
+
+
+CONTAINER_TYPES = ["COLUMN", "GRID", "TABS", "TAB", "ROW"]
+
+
+def get_dashboard_extra_filters(
 
 Review comment:
   @graceguo-supercat I thought this logic already existed in the backend and the idea we discussed was possibly refactoring the logic to ensure that this as well as the Celery warmup logic was using the same dashboard filter logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org