You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xingyingone (via GitHub)" <gi...@apache.org> on 2024/01/02 11:16:03 UTC
[PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
xingyingone opened a new pull request, #29426:
URL: https://github.com/apache/doris/pull/29426
[fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block
## Proposed changes
Issue Number: close #29387
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1873917732
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit a24fa676662dc89476e5dcc29d6102bfc9399597, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5448 5106 5117 5106
q2 401 174 161 161
q3 1453 1198 1176 1176
q4 1090 820 793 793
q5 3146 3182 3126 3126
q6 225 140 140 140
q7 995 563 525 525
q8 2154 2194 2237 2194
q9 6737 6676 6682 6676
q10 3183 3172 3102 3102
q11 344 231 222 222
q12 386 242 236 236
q13 4395 3646 3660 3646
q14 254 221 204 204
q15 592 548 541 541
q16 452 394 434 394
q17 1052 541 473 473
q18 7082 6821 6809 6809
q19 1643 1553 1411 1411
q20 613 353 334 334
q21 2924 2486 2494 2486
q22 405 324 313 313
Total cold run time: 44974 ms
Total hot run time: 40068 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5132 5092 5100 5092
q2 339 245 249 245
q3 3361 3322 3315 3315
q4 2149 1995 2002 1995
q5 5928 5911 5914 5911
q6 228 130 125 125
q7 2385 1914 1882 1882
q8 3540 3677 3633 3633
q9 9043 8987 8950 8950
q10 3877 3940 3923 3923
q11 580 512 480 480
q12 790 662 656 656
q13 3875 3182 3190 3182
q14 313 280 261 261
q15 614 537 538 537
q16 537 507 522 507
q17 2030 1813 1786 1786
q18 8733 8380 8364 8364
q19 1736 1652 1703 1652
q20 2315 1999 1988 1988
q21 5692 5203 5279 5203
q22 564 509 489 489
Total cold run time: 63761 ms
Total hot run time: 60176 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1873925683
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit a24fa676662dc89476e5dcc29d6102bfc9399597, data reload: false
------ Round 1 ----------------------------------
q1 17641 5672 5030 5030
q2 2016 153 141 141
q3 10535 1104 1141 1104
q4 10193 785 803 785
q5 7813 2927 2845 2845
q6 211 138 137 137
q7 903 556 500 500
q8 9333 1995 2000 1995
q9 6798 6397 6359 6359
q10 8204 2983 2963 2963
q11 420 219 223 219
q12 388 237 234 234
q13 18010 3634 3615 3615
q14 240 220 208 208
q15 568 533 543 533
q16 454 392 379 379
q17 960 502 497 497
q18 7204 6673 6700 6673
q19 1595 1399 1299 1299
q20 737 338 325 325
q21 2837 2460 2465 2460
q22 374 326 324 324
Total cold run time: 107434 ms
Total hot run time: 38625 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5111 5046 5023 5023
q2 337 259 253 253
q3 3304 3242 3254 3242
q4 2089 2000 2019 2000
q5 5811 5778 5802 5778
q6 212 125 126 125
q7 2303 1904 1910 1904
q8 3388 3430 3451 3430
q9 8844 8749 8728 8728
q10 3762 3846 3814 3814
q11 588 500 504 500
q12 809 637 645 637
q13 7824 3191 3220 3191
q14 289 275 260 260
q15 601 534 527 527
q16 551 503 506 503
q17 1933 1788 1777 1777
q18 8675 8330 8261 8261
q19 1618 1576 1626 1576
q20 2198 1963 1960 1960
q21 5542 5249 5254 5249
q22 520 501 453 453
Total cold run time: 66309 ms
Total hot run time: 59191 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1873929352
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.6 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.0 seconds inserted 10000000 Rows, about 357K ops/s
storage size: 17183905560 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1874794181
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #29426:
URL: https://github.com/apache/doris/pull/29426#discussion_r1439414984
##########
be/src/vec/olap/block_reader.cpp:
##########
@@ -429,12 +438,16 @@ Status BlockReader::_unique_key_next_block(Block* block, bool* eof) {
return Status::OK();
}
-void BlockReader::_insert_data_normal(MutableColumns& columns) {
+Status BlockReader::_insert_data_normal(MutableColumns& columns) {
auto block = _next_row.block.get();
- for (auto idx : _normal_columns_idx) {
- columns[_return_columns_loc[idx]]->insert_from(*block->get_by_position(idx).column,
- _next_row.row_pos);
- }
+
+ RETURN_IF_CATCH_EXCEPTION({
+ for (auto idx : _normal_columns_idx) {
+ columns[_return_columns_loc[idx]]->insert_from(*block->get_by_position(idx).column,
+ _next_row.row_pos);
+ }
+ });
+ return Status::OK();
Review Comment:
line 450 is useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1874099544
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit af7af0a3c0e87332313baeb8be41f35370df8f97, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5573 5193 5138 5138
q2 391 173 158 158
q3 1464 1178 1153 1153
q4 1108 831 842 831
q5 3109 3066 3114 3066
q6 228 136 137 136
q7 1016 566 526 526
q8 2159 2272 2225 2225
q9 6690 6651 6665 6651
q10 3181 3161 3203 3161
q11 331 223 217 217
q12 377 239 241 239
q13 4398 3696 3676 3676
q14 249 210 222 210
q15 603 547 555 547
q16 455 392 416 392
q17 1043 490 542 490
q18 7091 6794 6719 6719
q19 1647 1538 1491 1491
q20 563 363 385 363
q21 2918 2410 2430 2410
q22 412 322 344 322
Total cold run time: 45006 ms
Total hot run time: 40121 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5134 5135 5125 5125
q2 338 256 262 256
q3 3388 3311 3286 3286
q4 2162 2053 2050 2050
q5 5960 5937 5922 5922
q6 227 124 130 124
q7 2357 1889 1935 1889
q8 3584 3660 3695 3660
q9 9140 9042 9002 9002
q10 3882 3922 3908 3908
q11 581 469 491 469
q12 803 698 666 666
q13 3900 3219 3194 3194
q14 296 281 272 272
q15 592 540 549 540
q16 544 539 506 506
q17 2046 1797 1845 1797
q18 8738 8324 8335 8324
q19 1748 1671 1675 1671
q20 2294 1997 1991 1991
q21 5722 5335 5295 5295
q22 591 528 513 513
Total cold run time: 64027 ms
Total hot run time: 60460 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1873924844
TeamCity be ut coverage result:
Function Coverage: 36.63% (8612/23513)
Line Coverage: 28.68% (69993/244027)
Region Coverage: 27.67% (36233/130952)
Branch Coverage: 24.36% (18509/75976)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a24fa676662dc89476e5dcc29d6102bfc9399597_a24fa676662dc89476e5dcc29d6102bfc9399597/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1874108381
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.36 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.3 seconds inserted 10000000 Rows, about 353K ops/s
storage size: 17184252571 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1874794161
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1873936186
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools
```
TPC-DS sf100 test result on commit a24fa676662dc89476e5dcc29d6102bfc9399597, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 945 373 348 348
query2 6424 1799 1899 1799
query3 6665 204 199 199
query4 27519 22346 22305 22305
query5 5878 556 523 523
query6 266 182 185 182
query7 4593 277 257 257
query8 232 202 194 194
query9 8224 2650 2710 2650
query10 450 241 262 241
query11 16247 15660 15775 15660
query12 147 79 74 74
query13 1675 333 322 322
query14 12021 7048 7137 7048
query15 240 186 200 186
query16 6350 278 261 261
query17 1827 507 503 503
query18 1918 272 259 259
query19 268 141 138 138
query20 81 79 83 79
query21 184 97 98 97
query22 5067 4619 4763 4619
query23 32039 31363 31133 31133
query24 11856 2819 2829 2819
query25 571 355 349 349
query26 1714 144 146 144
query27 2843 288 278 278
query28 7132 1931 1929 1929
query29 2046 389 398 389
query30 289 144 147 144
query31 988 762 762 762
query32 89 60 57 57
query33 731 289 270 270
query34 856 439 437 437
query35 900 746 752 746
query36 1353 1184 1226 1184
query37 189 74 75 74
query38 3416 3280 3279 3279
query39 1324 1288 1263 1263
query40 305 92 87 87
query41 36 37 34 34
query42 93 88 95 88
query43 546 483 495 483
query44 1078 706 722 706
query45 201 187 179 179
query46 1084 664 652 652
query47 1590 1561 1554 1554
query48 332 270 258 258
query49 1195 327 313 313
query50 731 326 326 326
query51 5440 5309 5350 5309
query52 89 93 88 88
query53 217 137 151 137
query54 1378 565 573 565
query55 100 92 91 91
query56 208 206 198 198
query57 1046 925 951 925
query58 218 205 198 198
query59 2768 2589 2594 2589
query60 257 247 253 247
query61 87 86 93 86
query62 672 432 461 432
query63 169 152 141 141
query64 5933 1732 1684 1684
query65 3332 3272 3272 3272
query66 1262 334 326 326
query67 15805 15434 15302 15302
query68 10872 539 556 539
query69 543 254 256 254
query70 1699 1560 1495 1495
query71 493 227 224 224
query72 5373 3518 3592 3518
query73 2183 313 319 313
query74 7007 6433 6528 6433
query75 4845 2320 2257 2257
query76 6288 1128 1166 1128
query77 662 280 280 280
query78 9079 8809 8729 8729
query79 1087 497 496 496
query80 549 360 373 360
query81 458 214 207 207
query82 218 102 96 96
query83 178 140 134 134
query84 248 52 51 51
query85 953 286 270 270
query86 396 398 371 371
query87 3538 3404 3324 3324
query88 3660 2262 2269 2262
query89 329 268 252 252
query90 1854 208 196 196
query91 119 89 105 89
query92 60 53 51 51
query93 2258 507 438 438
query94 845 187 184 184
query95 468 419 401 401
query96 620 326 316 316
query97 4293 4177 4174 4174
query98 201 201 183 183
query99 1136 845 852 845
Total cold run time: 294241 ms
Total hot run time: 179341 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "xingyingone (via GitHub)" <gi...@apache.org>.
xingyingone commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1873897907
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #29426:
URL: https://github.com/apache/doris/pull/29426#discussion_r1439360800
##########
be/src/vec/olap/block_reader.cpp:
##########
@@ -429,12 +438,16 @@ Status BlockReader::_unique_key_next_block(Block* block, bool* eof) {
return Status::OK();
}
-void BlockReader::_insert_data_normal(MutableColumns& columns) {
+Status BlockReader::_insert_data_normal(MutableColumns& columns) {
Review Comment:
warning: method '_insert_data_normal' can be made static [readability-convert-member-functions-to-static]
```suggestion
static Status BlockReader::_insert_data_normal(MutableColumns& columns) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #29426:
URL: https://github.com/apache/doris/pull/29426#discussion_r1439416117
##########
be/src/vec/olap/block_reader.cpp:
##########
@@ -325,7 +328,10 @@ Status BlockReader::_agg_key_next_block(Block* block, bool* eof) {
_agg_data_counters.push_back(_last_agg_data_counter);
_last_agg_data_counter = 0;
- _insert_data_normal(target_columns);
+ auto status = _insert_data_normal(target_columns);
Review Comment:
RETURN_IF_ERROR(_insert_data_normal(target_columns));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1874099916
TeamCity be ut coverage result:
Function Coverage: 36.62% (8613/23518)
Line Coverage: 28.68% (70005/244098)
Region Coverage: 27.67% (36247/130992)
Branch Coverage: 24.36% (18514/76000)
Coverage Report: http://coverage.selectdb-in.cc/coverage/af7af0a3c0e87332313baeb8be41f35370df8f97_af7af0a3c0e87332313baeb8be41f35370df8f97/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29426:
URL: https://github.com/apache/doris/pull/29426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) [fix](scan) _insert_data_normal should catch exception when BlockReader::_unique_key_next_block [doris]
Posted by "xingyingone (via GitHub)" <gi...@apache.org>.
xingyingone commented on PR #29426:
URL: https://github.com/apache/doris/pull/29426#issuecomment-1874069043
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org