You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/11/21 21:41:40 UTC
[GitHub] jmeter pull request #335: Removed functions.util.* as they don't seem to be ...
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/335
Removed functions.util.* as they don't seem to be used (for many years).
## Description
Remove files which don't seem to be used, they have a TODO comment from 2008 and hasn't been meaningfully changed since 2003.
## How Has This Been Tested?
Ran unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter remove_unused_functions.util
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/335.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #335
----
commit 38a6e30435d8e56b1a51cb9c7637a90ab843d581
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-11-21T21:05:04Z
Removed functions.util.* as they don't seem to be used (for many years).
----
---
[GitHub] jmeter pull request #335: Removed functions.util.* as they don't seem to be ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/335
---
[GitHub] jmeter issue #335: Removed functions.util.* as they don't seem to be used (f...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/335
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/335?src=pr&el=h1) Report
> Merging [#335](https://codecov.io/gh/apache/jmeter/pull/335?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/5fc60e78ea8e49764096f8a75a16637a9e5b0682?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/335/graphs/tree.svg?src=pr&width=650&token=6Q7CI1wFSh&height=150)](https://codecov.io/gh/apache/jmeter/pull/335?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #335 +/- ##
============================================
+ Coverage 57.91% 57.91% +<.01%
+ Complexity 10025 10024 -1
============================================
Files 1148 1146 -2
Lines 73789 73781 -8
Branches 7328 7328
============================================
- Hits 42734 42733 -1
+ Misses 28577 28570 -7
Partials 2478 2478
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/335?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/335?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==) | `85.38% <0%> (-0.77%)` | `18% <0%> (-1%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/335?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/335?src=pr&el=footer). Last update [5fc60e7...38a6e30](https://codecov.io/gh/apache/jmeter/pull/335?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---