You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "zzxxiansheng (via GitHub)" <gi...@apache.org> on 2024/04/16 15:49:37 UTC
[PR] [ISSUE #119]Introduce dependencies for a unified return front-end format [eventmesh-dashboard]
zzxxiansheng opened a new pull request, #120:
URL: https://github.com/apache/eventmesh-dashboard/pull/120
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #issue_id
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #119] Introduce dependencies for a unified return front-end format [eventmesh-dashboard]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia merged PR #120:
URL: https://github.com/apache/eventmesh-dashboard/pull/120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #119] Introduce dependencies for a unified return front-end format [eventmesh-dashboard]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #120:
URL: https://github.com/apache/eventmesh-dashboard/pull/120#discussion_r1568168568
##########
eventmesh-dashboard-console/pom.xml:
##########
@@ -90,46 +86,37 @@
<version>1.8.0</version>
</dependency>
- <!-- Database -->
+ <!-- github laohu-->
<dependency>
- <groupId>com.alibaba</groupId>
- <artifactId>druid-spring-boot-starter</artifactId>
- <version>1.2.22</version>
+ <groupId>io.github.githublaohu</groupId>
+ <artifactId>dubbo-springmvc</artifactId>
+ <version>0.1.4</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-spring-boot-starter</artifactId>
+ </exclusion></exclusions>
Review Comment:
Misaligned xml tags
##########
eventmesh-dashboard-console/pom.xml:
##########
@@ -90,46 +86,37 @@
<version>1.8.0</version>
</dependency>
- <!-- Database -->
+ <!-- github laohu-->
<dependency>
- <groupId>com.alibaba</groupId>
- <artifactId>druid-spring-boot-starter</artifactId>
- <version>1.2.22</version>
+ <groupId>io.github.githublaohu</groupId>
+ <artifactId>dubbo-springmvc</artifactId>
+ <version>0.1.4</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-spring-boot-starter</artifactId>
+ </exclusion></exclusions>
Review Comment:
Misaligned xml tags
##########
eventmesh-dashboard-console/pom.xml:
##########
@@ -90,46 +86,37 @@
<version>1.8.0</version>
</dependency>
- <!-- Database -->
+ <!-- github laohu-->
<dependency>
- <groupId>com.alibaba</groupId>
- <artifactId>druid-spring-boot-starter</artifactId>
- <version>1.2.22</version>
+ <groupId>io.github.githublaohu</groupId>
+ <artifactId>dubbo-springmvc</artifactId>
+ <version>0.1.4</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-spring-boot-starter</artifactId>
+ </exclusion></exclusions>
Review Comment:
Misaligned xml tags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #119] Introduce dependencies for a unified return front-end format [eventmesh-dashboard]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #120:
URL: https://github.com/apache/eventmesh-dashboard/pull/120#discussion_r1567619127
##########
eventmesh-dashboard-console/src/main/resources/application-dev.yml:
##########
@@ -53,5 +53,10 @@ logging:
mybatis:
type-aliases-package: org.apache.eventmesh.dashboard.console.entity
+decoration:
+ constantConfig:
+ all: true
+ corsEnable: true
Review Comment:
Please leave some comments describing each config's meaning. Since there isn't any document others can find for reference.
##########
eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/controller/MetricsController.java:
##########
@@ -1,39 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.eventmesh.dashboard.console.controller;
-
-import org.apache.eventmesh.dashboard.common.dto.Result;
-
-import org.springframework.web.bind.annotation.GetMapping;
-import org.springframework.web.bind.annotation.RestController;
-
-import com.alibaba.druid.stat.DruidStatManagerFacade;
-
-@RestController
-public class MetricsController {
-
- @GetMapping("/druid/stat")
- public Object druidStat() {
- return DruidStatManagerFacade.getInstance().getDataSourceStatDataList();
- }
-
- @GetMapping("/hello")
- public Result<String> hello() {
- return Result.success("Hello, EventMesh Dashboard!");
- }
-}
Review Comment:
We'd better keep this endpoint for service online testing.
##########
eventmesh-dashboard-console/pom.xml:
##########
@@ -36,46 +36,30 @@
</properties>
<dependencies>
- <!-- Spring Boot Starter -->
- <dependency>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-web</artifactId>
- </dependency>
-
<!-- EventMesh Dashboard modules -->
- <dependency>
- <groupId>org.apache.eventmesh.dashboard.common</groupId>
- <artifactId>eventmesh-dashboard-common</artifactId>
- <version>0.0.1-SNAPSHOT</version>
- </dependency>
<dependency>
<groupId>org.apache.eventmesh.dashboard.core</groupId>
<artifactId>eventmesh-dashboard-core</artifactId>
<version>0.0.1-SNAPSHOT</version>
</dependency>
- <dependency>
- <groupId>org.apache.eventmesh.dashboard.service</groupId>
- <artifactId>eventmesh-dashboard-service</artifactId>
- <version>0.0.1-SNAPSHOT</version>
- </dependency>
Review Comment:
Why these module deps are removed? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #119] Introduce dependencies for a unified return front-end format [eventmesh-dashboard]
Posted by "zzxxiansheng (via GitHub)" <gi...@apache.org>.
zzxxiansheng commented on code in PR #120:
URL: https://github.com/apache/eventmesh-dashboard/pull/120#discussion_r1567662744
##########
eventmesh-dashboard-console/pom.xml:
##########
@@ -36,46 +36,30 @@
</properties>
<dependencies>
- <!-- Spring Boot Starter -->
- <dependency>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-web</artifactId>
- </dependency>
-
<!-- EventMesh Dashboard modules -->
- <dependency>
- <groupId>org.apache.eventmesh.dashboard.common</groupId>
- <artifactId>eventmesh-dashboard-common</artifactId>
- <version>0.0.1-SNAPSHOT</version>
- </dependency>
<dependency>
<groupId>org.apache.eventmesh.dashboard.core</groupId>
<artifactId>eventmesh-dashboard-core</artifactId>
<version>0.0.1-SNAPSHOT</version>
</dependency>
- <dependency>
- <groupId>org.apache.eventmesh.dashboard.service</groupId>
- <artifactId>eventmesh-dashboard-service</artifactId>
- <version>0.0.1-SNAPSHOT</version>
- </dependency>
Review Comment:
The EventMesh dependency has been appended back, and the SpringBoot dependency is in the <!-- github laohu--> dependency
##########
eventmesh-dashboard-console/pom.xml:
##########
@@ -36,46 +36,30 @@
</properties>
<dependencies>
- <!-- Spring Boot Starter -->
- <dependency>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-web</artifactId>
- </dependency>
-
<!-- EventMesh Dashboard modules -->
- <dependency>
- <groupId>org.apache.eventmesh.dashboard.common</groupId>
- <artifactId>eventmesh-dashboard-common</artifactId>
- <version>0.0.1-SNAPSHOT</version>
- </dependency>
<dependency>
<groupId>org.apache.eventmesh.dashboard.core</groupId>
<artifactId>eventmesh-dashboard-core</artifactId>
<version>0.0.1-SNAPSHOT</version>
</dependency>
- <dependency>
- <groupId>org.apache.eventmesh.dashboard.service</groupId>
- <artifactId>eventmesh-dashboard-service</artifactId>
- <version>0.0.1-SNAPSHOT</version>
- </dependency>
Review Comment:
The EventMesh dependency has been appended back, and the SpringBoot dependency is in the <artifactId>dubbo-springmvc</artifactId> dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #119] Introduce dependencies for a unified return front-end format [eventmesh-dashboard]
Posted by "zzxxiansheng (via GitHub)" <gi...@apache.org>.
zzxxiansheng commented on code in PR #120:
URL: https://github.com/apache/eventmesh-dashboard/pull/120#discussion_r1567662744
##########
eventmesh-dashboard-console/pom.xml:
##########
@@ -36,46 +36,30 @@
</properties>
<dependencies>
- <!-- Spring Boot Starter -->
- <dependency>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-web</artifactId>
- </dependency>
-
<!-- EventMesh Dashboard modules -->
- <dependency>
- <groupId>org.apache.eventmesh.dashboard.common</groupId>
- <artifactId>eventmesh-dashboard-common</artifactId>
- <version>0.0.1-SNAPSHOT</version>
- </dependency>
<dependency>
<groupId>org.apache.eventmesh.dashboard.core</groupId>
<artifactId>eventmesh-dashboard-core</artifactId>
<version>0.0.1-SNAPSHOT</version>
</dependency>
- <dependency>
- <groupId>org.apache.eventmesh.dashboard.service</groupId>
- <artifactId>eventmesh-dashboard-service</artifactId>
- <version>0.0.1-SNAPSHOT</version>
- </dependency>
Review Comment:
The EventMesh dependency has been appended back, and the SpringBoot dependency is in the <!-- github laohu--> dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #119] Introduce dependencies for a unified return front-end format [eventmesh-dashboard]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #120:
URL: https://github.com/apache/eventmesh-dashboard/pull/120#discussion_r1568168233
##########
eventmesh-dashboard-console/pom.xml:
##########
@@ -36,46 +36,30 @@
</properties>
<dependencies>
- <!-- Spring Boot Starter -->
- <dependency>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-web</artifactId>
- </dependency>
-
<!-- EventMesh Dashboard modules -->
- <dependency>
- <groupId>org.apache.eventmesh.dashboard.common</groupId>
- <artifactId>eventmesh-dashboard-common</artifactId>
- <version>0.0.1-SNAPSHOT</version>
- </dependency>
<dependency>
<groupId>org.apache.eventmesh.dashboard.core</groupId>
<artifactId>eventmesh-dashboard-core</artifactId>
<version>0.0.1-SNAPSHOT</version>
</dependency>
- <dependency>
- <groupId>org.apache.eventmesh.dashboard.service</groupId>
- <artifactId>eventmesh-dashboard-service</artifactId>
- <version>0.0.1-SNAPSHOT</version>
- </dependency>
Review Comment:
Better declare `dubbo-springmvc` has some important transitive dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org