Re: [PR] [SPARK-45762][CORE] Support shuffle managers defined in user jars by changing startup order [spark]

["mridulm (via GitHub)" <gi...@apache.org>]

mridulm commented on PR #43627:
URL: https://github.com/apache/spark/pull/43627#issuecomment-1931474172

   @dongjoon-hyun, tt is `@DeveloperApi` from point of view of usage - `SparkEnv` is not expected to be created by users, as some of the constructor parameters are not externally visible (`RpcEnv`, for example, cannot be created as it is `private[spark]`). There have been changes to its constructor in the past as well, after it was marked `@DeveloperApi` - though to be fair, these were a while back.
   
   In general, I am conflicted about trying to preserve compatibility for things which are clearly private to spark - it inhibits the ability for the project to evolve: especially around major version boundaries (though we do have a lot of these instances where we try to maintain compatibility).
   
   Given how long `SparkEnv` has been around, I can see valid case being made for adding a constructor which preserves earlier signature. Thiughts @tgravescs ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org