You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/01 05:56:22 UTC

[GitHub] [spark] zhengruifeng opened a new pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

zhengruifeng opened a new pull request #31409:
URL: https://github.com/apache/spark/pull/31409


   ### What changes were proposed in this pull request?
   when the child rdd has only one partition, skip the shuffle
   
   
   ### Why are the changes needed?
   avoid unnecessary shuffle
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   existing testsuites
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-770612070


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39294/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-770647267


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39294/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-771641032


   We may have more operators that adding shuffle in the `doExecute` method instead of the planner, but this fix looks correct to me. Also cc @viirya @maropu 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-772225191


   thanks, merging to master!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-770626488


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39294/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-770597884


   **[Test build #134709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134709/testReport)** for PR 31409 at commit [`097d1f9`](https://github.com/apache/spark/commit/097d1f90edff0906ca6d79000981beb9f24a7185).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31409:
URL: https://github.com/apache/spark/pull/31409


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-771641032


   We may have more operators that adding shuffle in the `doExecute` method instead of the planner, but this fix looks correct to me. Also cc @viirya @maropu 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-770647267


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39294/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-772261328


   thanks all for reviewing!
   
   > We may have more operators that adding shuffle in the doExecute method instead of the planner
   
   I will look for other similar operators that may skip shuffle like this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-770760338


   **[Test build #134709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134709/testReport)** for PR 31409 at commit [`097d1f9`](https://github.com/apache/spark/commit/097d1f90edff0906ca6d79000981beb9f24a7185).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-770592553


   testCode:
   ```
   val df = spark.read.format("libsvm").load("/d0/Dev/Opensource/spark/data/mllib/sample_multiclass_classification_data.txt")
   
   df.rdd.getNumPartitions
   
   df.sort('label).limit(100).show
   ```
   
   master:
   ![limit-job-2021-02-01-12-48-06](https://user-images.githubusercontent.com/7322292/106420357-686fe380-6495-11eb-9bd7-e2adbe26d425.png)
   
   ![limit-master-2021-02-01-12-47-29](https://user-images.githubusercontent.com/7322292/106420368-7160b500-6495-11eb-9af1-34f2bced4dbf.png)
   
   
   this PR:
   ![limit-job-pr-2021-02-01-13-00-41](https://user-images.githubusercontent.com/7322292/106420382-79b8f000-6495-11eb-9d4e-59fb2a783731.png)
   
   ![limit-pr-2021-02-01-13-01-40](https://user-images.githubusercontent.com/7322292/106420389-82112b00-6495-11eb-957b-b2510f6fddae.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-772287363


   late lgtm


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-770597884


   **[Test build #134709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134709/testReport)** for PR 31409 at commit [`097d1f9`](https://github.com/apache/spark/commit/097d1f90edff0906ca6d79000981beb9f24a7185).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-770763425


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134709/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31409: [SPARK-34307][SQL] TakeOrderedAndProjectExec avoid shuffle if input rdd has single partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31409:
URL: https://github.com/apache/spark/pull/31409#issuecomment-770763425


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134709/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org