You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2026/06/08 07:06:29 UTC
[PR] [SPARK-57262][SQL][WEBUI][4.1] Job description derived from a query should respect `spark.sql.redaction.string.regex` [spark]
sarutak opened a new pull request, #56364:
URL: https://github.com/apache/spark/pull/56364
### What changes were proposed in this pull request?
This PR changes `SparkSQLDriver.scala` to redact a query before `setJobDescription`.
### Why are the changes needed?
In the current implementation, when a query is executed through `SparkSQLDriver`, redaction is done in `SQLExecution.scala` so the description in the table on the `/SQL` page is redacted.
<img width="488" height="252" alt="sql-page-4 1" src="https://github.com/user-attachments/assets/bec6cd3d-c655-4bb2-9e95-5d0efb86999a" />
But the description in the table on the `/jobs` page is not redacted.
<img width="444" height="162" alt="jobs-page-before-4 1" src="https://github.com/user-attachments/assets/a6c93c26-2a64-4d41-ae1a-23ac77e38f84" />
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
Added new test and confirmed the test `SQL execution description should respect spark.sql.redaction.string.regex` added in #56358 passed.
Also confirmed the description is redacted in UI.
```
$ bin/spark-sql --conf spark.sql.redaction.string.regex="secret.*=.*"
spark-sql (default)> CREATE TABLE test1(secret string);
spark-sql (default)> SELECT * FROM test1 WHERE secret=1;
```
<img width="601" height="205" alt="jobs-page-after-4 1" src="https://github.com/user-attachments/assets/c21ae7cc-1089-4e3c-828a-ad022cd2492f" />
### Was this patch authored or co-authored using generative AI tooling?
Kiro CLI / Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57262][SQL][WEBUI][4.1] Job description derived from a query should respect `spark.sql.redaction.string.regex` [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak closed pull request #56364: [SPARK-57262][SQL][WEBUI][4.1] Job description derived from a query should respect `spark.sql.redaction.string.regex`
URL: https://github.com/apache/spark/pull/56364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57262][SQL][WEBUI][4.1] Job description derived from a query should respect `spark.sql.redaction.string.regex` [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #56364:
URL: https://github.com/apache/spark/pull/56364#issuecomment-4657129698
Merged to `branch-4.1`. Thank you @dongjoon-hyun for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org