You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2020/07/16 08:08:00 UTC
[jira] [Commented] (IGNITE-13016) Fix backward checking of failed
node.
[ https://issues.apache.org/jira/browse/IGNITE-13016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158994#comment-17158994 ]
Ignite TC Bot commented on IGNITE-13016:
----------------------------------------
{panel:title=Branch: [pull/7838/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7838/head] Base: [master] : New Tests (8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Service Grid{color} [[tests 4|https://ci.ignite.apache.org/viewLog.html?buildId=5462169]]
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=eb37c448-46e6-47f1-90c3-e2c1232ce3e0, topVer=0, nodeId8=07632a1b, msg=, type=NODE_JOINED, tstamp=1594738092959], val2=AffinityTopologyVersion [topVer=6570610929897650521, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=eb37c448-46e6-47f1-90c3-e2c1232ce3e0, topVer=0, nodeId8=07632a1b, msg=, type=NODE_JOINED, tstamp=1594738092959], val2=AffinityTopologyVersion [topVer=6570610929897650521, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=90486dd4371-1cb86db9-6955-413c-a8bc-184a9dae4984, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=dc276d8e-243d-4c5a-ae8e-ab4ab9525610, topVer=0, nodeId8=dc276d8e, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1594738092959]], val2=AffinityTopologyVersion [topVer=6331264228940651374, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=90486dd4371-1cb86db9-6955-413c-a8bc-184a9dae4984, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=dc276d8e-243d-4c5a-ae8e-ab4ab9525610, topVer=0, nodeId8=dc276d8e, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1594738092959]], val2=AffinityTopologyVersion [topVer=6331264228940651374, minorTopVer=0]]] - PASSED{color}
{color:#00008b}Service Grid (legacy mode){color} [[tests 4|https://ci.ignite.apache.org/viewLog.html?buildId=5462170]]
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=b5e153ec-563e-4f60-8a4c-10d4a07635be, topVer=0, nodeId8=cb4a3e0c, msg=, type=NODE_JOINED, tstamp=1594738174507], val2=AffinityTopologyVersion [topVer=2298789891461322797, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=b5e153ec-563e-4f60-8a4c-10d4a07635be, topVer=0, nodeId8=cb4a3e0c, msg=, type=NODE_JOINED, tstamp=1594738174507], val2=AffinityTopologyVersion [topVer=2298789891461322797, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=f2a6dcd4371-42ed2f0b-c0c4-4ad3-be48-9a06bb65c82d, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=feefc9bc-3741-48da-8a92-9d7d5732f937, topVer=0, nodeId8=feefc9bc, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1594738174507]], val2=AffinityTopologyVersion [topVer=1483823403640769579, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=f2a6dcd4371-42ed2f0b-c0c4-4ad3-be48-9a06bb65c82d, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=feefc9bc-3741-48da-8a92-9d7d5732f937, topVer=0, nodeId8=feefc9bc, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1594738174507]], val2=AffinityTopologyVersion [topVer=1483823403640769579, minorTopVer=0]]] - PASSED{color}
{panel}
[TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5462190&buildTypeId=IgniteTests24Java8_RunAll]
> Fix backward checking of failed node.
> -------------------------------------
>
> Key: IGNITE-13016
> URL: https://issues.apache.org/jira/browse/IGNITE-13016
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Vladimir Steshin
> Assignee: Vladimir Steshin
> Priority: Major
> Labels: iep-45
> Fix For: 2.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Backward node connection checking looks wierd. What we might improve are:
> 1) Addresses checking could be done in parrallel, not sequentially.
> {code:java}
> for (InetSocketAddress addr : nodeAddrs) {
> // Connection refused may be got if node doesn't listen
> // (or blocked by firewall, but anyway assume it is dead).
> if (!isConnectionRefused(addr)) {
> liveAddr = addr;
> break;
> }
> }
> {code}
> 2) Any io-exception should be considered as failed connection, not only connection-refused:
> {code:java}
> catch (ConnectException e) {
> return true;
> }
> catch (IOException e) {
> return false;
> }
> {code}
> 3) Timeout on connection checking should not be constant or hardcode:
> {code:java}
> sock.connect(addr, 100);
> {code}
> 4) Decision to check connection should rely on configured exchange timeout, no on the ping interval
> {code:java}
> // We got message from previous in less than double connection check interval.
> boolean ok = rcvdTime + U.millisToNanos(connCheckInterval) * 2 >= now;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)