You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "tvalentyn (via GitHub)" <gi...@apache.org> on 2023/12/02 00:32:11 UTC

Re: [PR] Add UUID to the hex object to avoid collisions [beam]

tvalentyn commented on code in PR #29542:
URL: https://github.com/apache/beam/pull/29542#discussion_r1412682744


##########
sdks/python/apache_beam/ml/transforms/handlers.py:
##########
@@ -201,6 +198,8 @@ class MergeDicts(beam.DoFn):
   def process(self, element):
     _, element = element
     new_dict = {}
+    # Assertion could fail due to UUID collision.

Review Comment:
   @AnandInguva please check that this condition makes sense. In particular, are there exactly two elements per key or two elements per each transformation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org