[GitHub] markusthoemmes commented on a change in pull request #3042: Make the log level configurable via ansible

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3042: Make the log level configurable via ansible
URL: https://github.com/apache/incubator-openwhisk/pull/3042#discussion_r154858588
 
 

 ##########
 File path: common/scala/src/main/resources/logback.xml
 ##########
 @@ -11,8 +11,10 @@
 
   <!-- Kafka -->
   <logger name="org.apache.kafka" level="ERROR" />
+
+  <variable name="WHISK_LOG_LEVEL" value="${WHISK_LOG_LEVEL:-INFO}" />
   
-  <root level="info">
+  <root level="${WHISK_LOG_LEVEL}">
 
 Review comment:
   I guess what @rabbah was after, is that this could now be changed to:
   
   ```
   // entirely omit the <variable> line
   <root level="whisk.loglevel">
   ```
   
   While defining:
   
   ```
   -e CONFIG_whisk_loglevel=...
   ```
   
   on the components.
   
   Your call on what you prefer.
   
   In any case: Is the double-definition even necessary in your case? Couldn't it be just:
   
   ```
   <root level="${WHISK_LOG_LEVEL:-INFO}">
   ```
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services