You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/04/02 08:04:56 UTC
svn commit: r1888293 - in
/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading:
PDMeshBasedShadingType.java PDShadingType4.java
PDTriangleBasedShadingType.java TriangleBasedShadingContext.java
Author: tilman
Date: Fri Apr 2 08:04:56 2021
New Revision: 1888293
URL: http://svn.apache.org/viewvc?rev=1888293&view=rev
Log:
PDFBOX-5134: Sonar fix
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDMeshBasedShadingType.java
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType4.java
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/TriangleBasedShadingContext.java
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDMeshBasedShadingType.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDMeshBasedShadingType.java?rev=1888293&r1=1888292&r2=1888293&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDMeshBasedShadingType.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDMeshBasedShadingType.java Fri Apr 2 08:04:56 2021
@@ -179,7 +179,8 @@ abstract class PDMeshBasedShadingType ex
{
float[][] color = new float[4][getNumberOfColorComponents()];
Point2D[] points = new Point2D[controlPoints];
- int pStart = 4, cStart = 2;
+ int pStart = 4;
+ int cStart = 2;
if (isFree)
{
pStart = 0;
@@ -240,7 +241,7 @@ abstract class PDMeshBasedShadingType ex
abstract Patch generatePatch(Point2D[] points, float[][] color);
@Override
- abstract public Rectangle2D getBounds(AffineTransform xform, Matrix matrix) throws IOException;
+ public abstract Rectangle2D getBounds(AffineTransform xform, Matrix matrix) throws IOException;
Rectangle2D getBounds(AffineTransform xform, Matrix matrix, int controlPoints)
throws IOException
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType4.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType4.java?rev=1888293&r1=1888292&r2=1888293&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType4.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType4.java Fri Apr 2 08:04:56 2021
@@ -130,7 +130,9 @@ public class PDShadingType4 extends PDTr
boolean eof = false;
while (!eof)
{
- Vertex p0, p1, p2;
+ Vertex p0;
+ Vertex p1;
+ Vertex p2;
Point2D[] ps;
float[][] cs;
int lastIndex;
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java?rev=1888293&r1=1888292&r2=1888293&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDTriangleBasedShadingType.java Fri Apr 2 08:04:56 2021
@@ -41,7 +41,7 @@ abstract class PDTriangleBasedShadingTyp
// value: same as the value of Range
private COSArray decode = null;
- private static final Log LOG = LogFactory.getLog(TriangleBasedShadingContext.class);
+ private static final Log LOG = LogFactory.getLog(PDTriangleBasedShadingType.class);
private int bitsPerCoordinate = -1;
private int bitsPerColorComponent = -1;
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/TriangleBasedShadingContext.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/TriangleBasedShadingContext.java?rev=1888293&r1=1888292&r2=1888293&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/TriangleBasedShadingContext.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/TriangleBasedShadingContext.java Fri Apr 2 08:04:56 2021
@@ -25,8 +25,7 @@ import java.awt.image.WritableRaster;
import java.io.IOException;
import java.util.List;
import java.util.Map;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
+
import org.apache.pdfbox.util.Matrix;
/**