You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2024/01/17 04:22:23 UTC

[PR] Making links in task logs as hyperlinks by preventing HTML injection [airflow]

amoghrajesh opened a new pull request, #36829:
URL: https://github.com/apache/airflow/pull/36829

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   We had to revert the change https://github.com/apache/airflow/pull/36826 due to the potential risk of HTML injection. To fix that properly, I have added a fix which does the following:
   1. If any tags are present in the log lines, it will sanitize it by escaping the HTML so that the UI wont render it
   2. If not, it will proceed as usual, which is convert it to a hyperlink
   
   Added the following in a task of a DAG to test it:
   ```
           print("http://example.com")
           print("http://apache.org/</a><b>bad-stuff!</b>")
           print("back to normal")
           print("<b>does this work?</b>")
           print("<div onmouseover=\"alert('hi');\">hello</div>")
   ```
   
   
   Results look like so:
   ![image](https://github.com/apache/airflow/assets/35884252/517d29f4-26c6-4f45-a929-517c6f8f97c3)
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org