You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2012/09/05 10:39:08 UTC

[jira] [Assigned] (WICKET-4625) ServletWebRequest#getContextRelativeUrl() sometimes chops off leading characters

     [ https://issues.apache.org/jira/browse/WICKET-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reassigned WICKET-4625:
---------------------------------------

    Assignee: Martin Grigorov
    
> ServletWebRequest#getContextRelativeUrl() sometimes chops off leading characters
> --------------------------------------------------------------------------------
>
>                 Key: WICKET-4625
>                 URL: https://issues.apache.org/jira/browse/WICKET-4625
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.5.7
>            Reporter: Darryl L. Miles
>            Assignee: Martin Grigorov
>         Attachments: 0001-WICKET-4625-ServletWebRequest-getContextRelativeUrl-.patch
>
>
> This patch reduces the number of nonsense return value this method might produce.  I have clarified the in JavaDoc the expected inputs to the method.  It is still possible to still get a nonsense return values in some use cases, all scenarios are documented and tested in a new test case.
> This method presumes that the input "uri" on the 1st argument always has the ContextPath and then the FilterPrefix on the front of the URL.
> Some unit tests were actually checking the nonsense return values were being returned these have been updated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira