You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2026/03/16 13:01:00 UTC

(superset) branch master updated: fix(FilterBar): reduce padded space between filter header and first filter (#38646)

This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new afe093f1ca5 fix(FilterBar): reduce padded space between filter header and first filter (#38646)
afe093f1ca5 is described below

commit afe093f1ca5fc7b35254f95f545f1770a4cc11d2
Author: Đỗ Trọng Hải <41...@users.noreply.github.com>
AuthorDate: Mon Mar 16 20:00:52 2026 +0700

    fix(FilterBar): reduce padded space between filter header and first filter (#38646)
    
    Signed-off-by: hainenber <do...@gmail.com>
---
 .../dashboard/components/nativeFilters/FilterBar/Header/index.tsx   | 6 +++---
 .../src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx   | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
index 6fae1d5c6ed..10650a79ade 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
@@ -33,6 +33,7 @@ const TitleArea = styled.div`
     justify-content: space-between;
     margin: 0;
     padding: 0 ${theme.sizeUnit * 2}px ${theme.sizeUnit * 2}px;
+    padding-bottom: 0; /* Works with other changes in PR https://github.com/apache/superset/pull/38646 to reduces space between filter header and 1st filter */
 
     & > span {
       font-size: ${theme.fontSizeLG}px;
@@ -56,9 +57,8 @@ const HeaderButton = styled(Button)`
 
 const Wrapper = styled.div`
   ${({ theme }) => `
-    padding: ${theme.sizeUnit * 3}px ${theme.sizeUnit * 2}px ${
-      theme.sizeUnit
-    }px;
+    padding: ${theme.sizeUnit * 3}px ${theme.sizeUnit * 2}px;
+    padding-bottom: 0; /* Works with other changes in PR https://github.com/apache/superset/pull/38646 to reduces space between filter header and 1st filter */
   `}
 `;
 
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
index 9db9b8b0579..fa9ab3c4183 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
@@ -119,6 +119,7 @@ const FilterControlsWrapper = styled.div`
     flex-direction: column;
     gap: ${theme.sizeUnit * 2}px;
     padding: ${theme.sizeUnit * 4}px;
+    padding-top: 0; /* Works with other changes in PR https://github.com/apache/superset/pull/38646 to reduces space between filter header and 1st filter */
     // 108px padding to make room for buttons with position: absolute
     padding-bottom: ${theme.sizeUnit * 27}px;
   `}