[jira] [Commented] (CB-12384) Add Cordova framework target to iOS

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868379#comment-15868379 ] 

ASF GitHub Bot commented on CB-12384:
-------------------------------------

GitHub user khawkins opened a pull request:

    https://github.com/apache/cordova-ios/pull/289

    CB-12384 ios: Add Cocoa Touch Framework target for CordovaLib functionality

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Adds a Cocoa Touch Framework target to the CordovaLib project, in anticipation of support for tools like Carthage (parent issue: [CB-12050](https://issues.apache.org/jira/browse/CB-12050)).
    
    ### What testing has been done on this change?
    
    In the cordova-ios Xcode workspace under tests/, An app target was added to consume the framework target as part of the unit testing process.  All tests are verified as passing in both targets.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khawkins/cordova-ios CB-12384

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #289
    
----

----


> Add Cordova framework target to iOS
> -----------------------------------
>
>                 Key: CB-12384
>                 URL: https://issues.apache.org/jira/browse/CB-12384
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: CordovaLib, iOS
>    Affects Versions: Master
>            Reporter: Kevin Hawkins
>   Original Estimate: 40h
>  Remaining Estimate: 40h
>
> Carthage support requires a dynamic framework target for Cordova.  It should be possible to create a framework target that lives side by side with the existing static library target (CordovaLib), sharing code, tests, etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org