You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/01/17 04:56:47 UTC
Review Request 17029: Added a List type in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17029/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos-git
Description
-------
Similarly to set.hpp, this was needed to create Lists from a list of arguments:
List<int>(1, 2, 3, 4, 5, 6)
We remove this when c++11 is required, since lists can be constructed with std::initializer_list.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 0725722ed99695ebe6d2410c4704d6f1b8d0ff7f
3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/17029/diff/
Testing
-------
I ended up testing this through subsequent changes using List.
Thanks,
Ben Mahler
Re: Review Request 17029: Added a List type in stout.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17029/#review32201
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp
<https://reviews.apache.org/r/17029/#comment60915>
Add a LICENSE header here.
- Ben Mahler
On Jan. 17, 2014, 3:56 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17029/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 3:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Similarly to set.hpp, this was needed to create Lists from a list of arguments:
>
> List<int>(1, 2, 3, 4, 5, 6)
>
> We remove this when c++11 is required, since lists can be constructed with std::initializer_list.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 0725722ed99695ebe6d2410c4704d6f1b8d0ff7f
> 3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17029/diff/
>
>
> Testing
> -------
>
> I ended up testing this through subsequent changes using List.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 17029: Added a List type in stout.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17029/#review32391
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 17, 2014, 3:56 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17029/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 3:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Similarly to set.hpp, this was needed to create Lists from a list of arguments:
>
> List<int>(1, 2, 3, 4, 5, 6)
>
> We remove this when c++11 is required, since lists can be constructed with std::initializer_list.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 0725722ed99695ebe6d2410c4704d6f1b8d0ff7f
> 3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17029/diff/
>
>
> Testing
> -------
>
> I ended up testing this through subsequent changes using List.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 17029: Added a List type in stout.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17029/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 9:40 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Added licence and rebased, NNFR.
Repository: mesos-git
Description
-------
Similarly to set.hpp, this was needed to create Lists from a list of arguments:
List<int>(1, 2, 3, 4, 5, 6)
We remove this when c++11 is required, since lists can be constructed with std::initializer_list.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am d83ad25e9b177ca5eff501d6f2a072430bfaf1f6
3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/17029/diff/
Testing
-------
I ended up testing this through subsequent changes using List.
Thanks,
Ben Mahler
Re: Review Request 17029: Added a List type in stout.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17029/#review32208
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 17, 2014, 3:56 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17029/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 3:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Similarly to set.hpp, this was needed to create Lists from a list of arguments:
>
> List<int>(1, 2, 3, 4, 5, 6)
>
> We remove this when c++11 is required, since lists can be constructed with std::initializer_list.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 0725722ed99695ebe6d2410c4704d6f1b8d0ff7f
> 3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17029/diff/
>
>
> Testing
> -------
>
> I ended up testing this through subsequent changes using List.
>
>
> Thanks,
>
> Ben Mahler
>
>