You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Israel Ekpo <is...@aicer.org> on 2013/04/11 12:58:34 UTC
Review Request: FLUME-1621 - Document new MemoryChannel parameters in Flume
User Guide
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10417/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Providing documentation in user guide for new MemoryChannel parameters.
This addresses bug FLUME-1621.
https://issues.apache.org/jira/browse/FLUME-1621
Diffs
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7
Diff: https://reviews.apache.org/r/10417/diff/
Testing
-------
Thanks,
Israel Ekpo
Re: Review Request: FLUME-1621 - Document new MemoryChannel parameters in
Flume User Guide
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10417/#review22299
-----------------------------------------------------------
Ship it!
+1, looks good
- Mike Percy
On May 15, 2013, 3:42 a.m., Israel Ekpo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10417/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 3:42 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Providing documentation in user guide for new MemoryChannel parameters.
>
>
> This addresses bug FLUME-1621.
> https://issues.apache.org/jira/browse/FLUME-1621
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7
>
> Diff: https://reviews.apache.org/r/10417/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Israel Ekpo
>
>
Re: Review Request 10417: FLUME-1621 - Document new MemoryChannel parameters
in Flume User Guide
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10417/#review23291
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Alten-Lorenz
On May 15, 2013, 3:42 a.m., Israel Ekpo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10417/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 3:42 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-1621
> https://issues.apache.org/jira/browse/FLUME-1621
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Providing documentation in user guide for new MemoryChannel parameters.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7
>
> Diff: https://reviews.apache.org/r/10417/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Israel Ekpo
>
>
Re: Review Request: FLUME-1621 - Document new MemoryChannel parameters in
Flume User Guide
Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10417/
-----------------------------------------------------------
(Updated May 15, 2013, 3:42 a.m.)
Review request for Flume.
Description
-------
Providing documentation in user guide for new MemoryChannel parameters.
This addresses bug FLUME-1621.
https://issues.apache.org/jira/browse/FLUME-1621
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7
Diff: https://reviews.apache.org/r/10417/diff/
Testing
-------
N/A
Thanks,
Israel Ekpo
Re: Review Request: FLUME-1621 - Document new MemoryChannel parameters in
Flume User Guide
Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10417/
-----------------------------------------------------------
(Updated May 15, 2013, 3:41 a.m.)
Review request for Flume.
Description
-------
Providing documentation in user guide for new MemoryChannel parameters.
This addresses bug FLUME-1621.
https://issues.apache.org/jira/browse/FLUME-1621
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7
Diff: https://reviews.apache.org/r/10417/diff/
Testing
-------
N/A
Thanks,
Israel Ekpo
Re: Review Request: FLUME-1621 - Document new MemoryChannel parameters in
Flume User Guide
Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10417/
-----------------------------------------------------------
(Updated May 15, 2013, 3:36 a.m.)
Review request for Flume.
Description
-------
Providing documentation in user guide for new MemoryChannel parameters.
This addresses bug FLUME-1621.
https://issues.apache.org/jira/browse/FLUME-1621
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7
Diff: https://reviews.apache.org/r/10417/diff/
Testing
-------
N/A
Thanks,
Israel Ekpo
Re: Review Request: FLUME-1621 - Document new MemoryChannel parameters in
Flume User Guide
Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10417/
-----------------------------------------------------------
(Updated May 15, 2013, 3:33 a.m.)
Review request for Flume.
Changes
-------
Updated documentation based on review feedback.
Description
-------
Providing documentation in user guide for new MemoryChannel parameters.
This addresses bug FLUME-1621.
https://issues.apache.org/jira/browse/FLUME-1621
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7
Diff: https://reviews.apache.org/r/10417/diff/
Testing
-------
N/A
Thanks,
Israel Ekpo
Re: Review Request: FLUME-1621 - Document new MemoryChannel parameters in
Flume User Guide
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10417/#review20285
-----------------------------------------------------------
flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/10417/#comment41805>
How about changing this to "The maximum number of events the source can write to the channel or the sink can take from the channel in one transaction."
The channels don't actively take or put from source/into sink.
- Hari Shreedharan
On April 24, 2013, 12:13 p.m., Israel Ekpo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10417/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 12:13 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Providing documentation in user guide for new MemoryChannel parameters.
>
>
> This addresses bug FLUME-1621.
> https://issues.apache.org/jira/browse/FLUME-1621
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7
>
> Diff: https://reviews.apache.org/r/10417/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Israel Ekpo
>
>
Re: Review Request: FLUME-1621 - Document new MemoryChannel parameters in
Flume User Guide
Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10417/
-----------------------------------------------------------
(Updated April 24, 2013, 12:13 p.m.)
Review request for Flume.
Description
-------
Providing documentation in user guide for new MemoryChannel parameters.
This addresses bug FLUME-1621.
https://issues.apache.org/jira/browse/FLUME-1621
Diffs
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7
Diff: https://reviews.apache.org/r/10417/diff/
Testing (updated)
-------
N/A
Thanks,
Israel Ekpo