You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Fournier, Camille F. [Tech]" <Ca...@gs.com> on 2010/09/02 21:41:24 UTC
Re: (ZOOKEEPER-844) handle auth failure in java client
Hi all,
I would like to submit this patch into the 3.3 branch as well, since we are probably going to go into production with 3.3 and I'd rather not do a production release with a patched version of ZK if possible. I added a patch for this fix against the 3.3 branch to this ticket. Any idea of the odds of getting this in to the 3.3.2 release?
Thanks,
Camille
-----Original Message-----
From: Giridharan Kesavan (JIRA) [mailto:jira@apache.org]
Sent: Tuesday, August 31, 2010 7:25 PM
To: Fournier, Camille F. [Tech]
Subject: [jira] Updated: (ZOOKEEPER-844) handle auth failure in java client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-844:
-----------------------------------------
Status: Patch Available (was: Open)
> handle auth failure in java client
> ----------------------------------
>
> Key: ZOOKEEPER-844
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-844
> Project: Zookeeper
> Issue Type: Improvement
> Components: java client
> Affects Versions: 3.3.1
> Reporter: Camille Fournier
> Assignee: Camille Fournier
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-844.patch
>
>
> ClientCnxn.java currently has the following code:
> if (replyHdr.getXid() == -4) {
> // -2 is the xid for AuthPacket
> // TODO: process AuthPacket here
> if (LOG.isDebugEnabled()) {
> LOG.debug("Got auth sessionid:0x"
> + Long.toHexString(sessionId));
> }
> return;
> }
> Auth failures appear to cause the server to disconnect but the client never gets a proper state change or notification that auth has failed, which makes handling this scenario very difficult as it causes the client to go into a loop of sending bad auth, getting disconnected, trying to reconnect, sending bad auth again, over and over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: (ZOOKEEPER-844) handle auth failure in java client
Posted by Patrick Hunt <ph...@apache.org>.
I don't see why we couldn't include it. Thanks!
Patrick
On Thu, Sep 2, 2010 at 12:41 PM, Fournier, Camille F. [Tech] <
Camille.Fournier@gs.com> wrote:
> Hi all,
>
> I would like to submit this patch into the 3.3 branch as well, since we are
> probably going to go into production with 3.3 and I'd rather not do a
> production release with a patched version of ZK if possible. I added a patch
> for this fix against the 3.3 branch to this ticket. Any idea of the odds of
> getting this in to the 3.3.2 release?
>
> Thanks,
> Camille
>
> -----Original Message-----
> From: Giridharan Kesavan (JIRA) [mailto:jira@apache.org]
> Sent: Tuesday, August 31, 2010 7:25 PM
> To: Fournier, Camille F. [Tech]
> Subject: [jira] Updated: (ZOOKEEPER-844) handle auth failure in java client
>
>
> [
> https://issues.apache.org/jira/browse/ZOOKEEPER-844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Giridharan Kesavan updated ZOOKEEPER-844:
> -----------------------------------------
>
> Status: Patch Available (was: Open)
>
> > handle auth failure in java client
> > ----------------------------------
> >
> > Key: ZOOKEEPER-844
> > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-844
> > Project: Zookeeper
> > Issue Type: Improvement
> > Components: java client
> > Affects Versions: 3.3.1
> > Reporter: Camille Fournier
> > Assignee: Camille Fournier
> > Fix For: 3.4.0
> >
> > Attachments: ZOOKEEPER-844.patch
> >
> >
> > ClientCnxn.java currently has the following code:
> > if (replyHdr.getXid() == -4) {
> > // -2 is the xid for AuthPacket
> > // TODO: process AuthPacket here
> > if (LOG.isDebugEnabled()) {
> > LOG.debug("Got auth sessionid:0x"
> > + Long.toHexString(sessionId));
> > }
> > return;
> > }
> > Auth failures appear to cause the server to disconnect but the client
> never gets a proper state change or notification that auth has failed, which
> makes handling this scenario very difficult as it causes the client to go
> into a loop of sending bad auth, getting disconnected, trying to reconnect,
> sending bad auth again, over and over.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>