You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Jonathan Park <pa...@gmail.com> on 2014/09/01 13:28:28 UTC

Re: Review Request 22658: ACCUMULO-2889: Batch metadata updates for new WALs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22658/
-----------------------------------------------------------

(Updated Sept. 1, 2014, 11:28 a.m.)


Review request for accumulo.


Changes
-------

Incorporating feedback from kturner. Removed the use of ThreadLocal and batching of updates happens in TabletServerLogger instead of in the writer class.


Bugs: ACCUMULO-2889
    https://issues.apache.org/jira/browse/ACCUMULO-2889


Repository: accumulo


Description
-------

Added additional methods to the Writer class to handle batching. 

Potential risks are that we're now holding onto the locks for a bit longer than we used to. All tablets present in a batch will have their logLock's locked until the batch is complete. 


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/client/impl/Writer.java d6762e7 
  server/base/src/main/java/org/apache/accumulo/server/util/InternalBatchWriter.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 463ca57 
  server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java f9fdacb 
  server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 97f2090 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java d25ee75 
  test/src/test/java/org/apache/accumulo/server/util/InternalBatchWriterIT.java PRE-CREATION 
  test/src/test/java/org/apache/accumulo/test/BatchMetadataUpdatesIT.java PRE-CREATION 

Diff: https://reviews.apache.org/r/22658/diff/


Testing
-------

Added a new IT.

We insert a few entries to tablets and ensure that the relevant entries appear in the WAL and Metadata Table.
One test case that isn't included yet is verifying that root + metadata table entries are entered correctly.


Thanks,

Jonathan Park