You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/07 13:41:12 UTC

[GitHub] [pulsar-client-node] shibd commented on a diff in pull request #258: Remove useless dependencies.

shibd commented on code in PR #258:
URL: https://github.com/apache/pulsar-client-node/pull/258#discussion_r1042219878


##########
.github/workflows/ci-pr-validation.yml:
##########
@@ -90,8 +90,8 @@ jobs:
       - name: Build Node binaries lib
         run: |
           yarn install --ignore-scripts

Review Comment:
   > Could you verify both yarn install and npm install?
   
   In fact, used `npm install` when building Windows as well as Linux Arch. This has verified that both yarn and npm can be used. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org