You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/13 17:12:31 UTC

[GitHub] mistercrunch commented on issue #6676: Run pre-test check before others in build matrix

mistercrunch commented on issue #6676: Run pre-test check before others in build matrix
URL: https://github.com/apache/incubator-superset/pull/6676#issuecomment-453847429
 
 
   Looks like it may increase the overall duration by up to 6-7 minutes though, unclear though as we do hit the parallelism limit (6?), but may pay for more parallelism in the future. Personally I prefer having the full report asap, like if there's an issue with JS tests and lint python, or python tests and flake8, might as well get it all in one pass. 
   
   [related] Pylint seems much longer than it should be, I tried upgrading it and it's actually worse >=2.0, there are open issues discussing how pylint + pandas hit major slowdowns. https://github.com/PyCQA/pylint/issues/2198 for the record.
   
   I didn't know about the pre-test feature in Travis though, I'll look into whether there's a a way to cache things in a smart way where we could save a lot of work. If we can build the JS bundle only once and reuse it across jest+cypress tests that'd be nice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org