You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Prateek Maheshwari (JIRA)" <ji...@apache.org> on 2017/04/17 17:51:41 UTC

[jira] [Commented] (SAMZA-1207) Samza should publish test utilities in a test artifact

    [ https://issues.apache.org/jira/browse/SAMZA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971395#comment-15971395 ] 

Prateek Maheshwari commented on SAMZA-1207:
-------------------------------------------

+1 for making these test utils/harnesses publicly available. I'd prefer to move the actual integration tests that use these to a different module (maybe "samza-integration-tests" or something similar) that won't be published to maven.

I think [~navina] didn't want to make StreamTaskTestUtil public. I agree, it does seem tightly coupled with the existing integration tests. But we can now add StreamApplicationIntegrationTestHarness to the list:
https://github.com/apache/samza/blob/master/samza-test/src/test/java/org/apache/samza/test/operator/StreamApplicationIntegrationTestHarness.java

I'm wondering if we need both Standalone and StreamApplication harnesses. Seems like a single harness (which essentially sets up Kafka and ZK) with utils for using with StreamApplication, Standalone and StreamTask would be cleaner. [~navina], [~jagadish1989@gmail.com], what do you think?


> Samza should publish test utilities in a test artifact
> ------------------------------------------------------
>
>                 Key: SAMZA-1207
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1207
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Jake Maes
>            Assignee: Jake Maes
>             Fix For: 0.13.0
>
>
> Samza has some handy tools in samza-test that are not published in a maven artifact. 
> For example:
> 1. https://github.com/apache/samza/blob/2a3a5ac7f21dc4213ff6ec96e11a798bff096d04/samza-test/src/test/java/org/apache/samza/test/StandaloneIntegrationTestHarness.java
> 2. https://github.com/apache/samza/blob/2a3a5ac7f21dc4213ff6ec96e11a798bff096d04/samza-test/src/test/scala/org/apache/samza/test/integration/StreamTaskTestUtil.scala
> However, these utilities are in the src/test/* directory of samza-test and are therefore not published to an artifact. 
> This ticket is to fix that. Two options come to mind:
> 1. Move all useful test utilities to the /src/main/* directory so they get published
> 2. Configure gradle/maven to publish a separate artifact for these. 
> I think #1 would be cleaner.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)