You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/30 00:18:02 UTC

[GitHub] [airflow] potiuk opened a new pull request #15080: Printing stats is faster now

potiuk opened a new pull request #15080:
URL: https://github.com/apache/airflow/pull/15080


   We are using much smaller and faster to pull debian image
   to get statistics.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #15080: Printing stats is faster now

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15080:
URL: https://github.com/apache/airflow/pull/15080#discussion_r603912924



##########
File path: scripts/ci/libraries/_docker_engine_resources.sh
##########
@@ -22,27 +22,25 @@ function docker_engine_resources::print_overall_stats() {
     echo "Overall resource statistics"
     echo
     docker stats --all --no-stream --no-trunc
-    docker run --rm --entrypoint /bin/bash "${AIRFLOW_CI_IMAGE}" -c "free -h"
-    df --human || true
+    docker run --rm --entrypoint /bin/bash "debian:buster-slim" -c "cat /proc/meminfo"
+    df -H || true

Review comment:
       Right. I had to change to shorter version (MacOS does not have `--human` switch - which is funny BTW).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a change in pull request #15080: Printing stats is faster now

Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15080:
URL: https://github.com/apache/airflow/pull/15080#discussion_r603776496



##########
File path: scripts/ci/libraries/_docker_engine_resources.sh
##########
@@ -22,27 +22,25 @@ function docker_engine_resources::print_overall_stats() {
     echo "Overall resource statistics"
     echo
     docker stats --all --no-stream --no-trunc
-    docker run --rm --entrypoint /bin/bash "${AIRFLOW_CI_IMAGE}" -c "free -h"
-    df --human || true
+    docker run --rm --entrypoint /bin/bash "debian:buster-slim" -c "cat /proc/meminfo"
+    df -H || true

Review comment:
       Is this intentional? `df --human` is 1024-based (same as `df -h`), but `df -H` is 1000-based (same as `df --si`).
   
   Otherwise lgtm.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a change in pull request #15080: Printing stats is faster now

Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15080:
URL: https://github.com/apache/airflow/pull/15080#discussion_r603776496



##########
File path: scripts/ci/libraries/_docker_engine_resources.sh
##########
@@ -22,27 +22,25 @@ function docker_engine_resources::print_overall_stats() {
     echo "Overall resource statistics"
     echo
     docker stats --all --no-stream --no-trunc
-    docker run --rm --entrypoint /bin/bash "${AIRFLOW_CI_IMAGE}" -c "free -h"
-    df --human || true
+    docker run --rm --entrypoint /bin/bash "debian:buster-slim" -c "cat /proc/meminfo"
+    df -H || true

Review comment:
       Is this intentional? `df --human` is 1024-based (same as `df -h`), but `df -H` is 100-based (same as `df --si`).
   
   Otherwise lgtm.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #15080: Better handling of docker command

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15080:
URL: https://github.com/apache/airflow/pull/15080


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #15080: Better handling of docker command

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15080:
URL: https://github.com/apache/airflow/pull/15080#issuecomment-810649047


   @mik-laj -> I think you complained about this once


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15080: Better handling of docker command

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15080:
URL: https://github.com/apache/airflow/pull/15080#issuecomment-810688567


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #15080: Better handling of docker command

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15080:
URL: https://github.com/apache/airflow/pull/15080#issuecomment-810648284


   I changed the topic of this one - I found that the stats were sometimes not printed was really the renamed docker command.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org