You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajani Karuturi <ra...@gmail.com> on 2014/04/24 07:45:30 UTC
Re: Review Request 20652: VR alerts for command failures during start and
option to stop the router incase of failures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/
-----------------------------------------------------------
(Updated April 24, 2014, 5:45 a.m.)
Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
Summary (updated)
-----------------
VR alerts for command failures during start and option to stop the router incase of failures
Repository: cloudstack-git
Description
-------
added a new configuration router.start.strict to optionally stop the router in case of command failures. Also added alerts for failures.
Diffs
-----
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 6d18f86
Diff: https://reviews.apache.org/r/20652/diff/
Testing
-------
Manually tested.
Thanks,
Rajani Karuturi
Re: Review Request 20652: VR alerts for command failures during start and
stop the router incase of failures
Posted by Rajani Karuturi <ra...@gmail.com>.
> On April 25, 2014, 10:58 a.m., Murali Reddy wrote:
> > Please use VirtualMachineGuru.finalizeStart as opportunity check the answers returned by the VR start command. This would avoid VR specific logic spilling to orchestration layer.
Hi Murali, updated the patch with the suggested changes.
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/#review41459
-----------------------------------------------------------
On April 28, 2014, 6:27 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20652/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 6:27 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added a new configuration router.start.strict to optionally stop the router in case of command failures. Also added alerts for failures.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 466b861
>
> Diff: https://reviews.apache.org/r/20652/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 20652: VR alerts for command failures during start and
option to stop the router incase of failures
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/#review41459
-----------------------------------------------------------
Please use VirtualMachineGuru.finalizeStart as opportunity check the answers returned by the VR start command. This would avoid VR specific logic spilling to orchestration layer.
- Murali Reddy
On April 24, 2014, 5:45 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20652/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 5:45 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added a new configuration router.start.strict to optionally stop the router in case of command failures. Also added alerts for failures.
>
>
> Diffs
> -----
>
> engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 6d18f86
>
> Diff: https://reviews.apache.org/r/20652/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 20652: CLOUDSTACK-6531: VR alerts for command failures
during start and stop the router incase of failures
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/#review42284
-----------------------------------------------------------
Commit 645516ee78a8117dfa221caa0fc8d4dfe521af2b in cloudstack's branch refs/heads/4.4-forward from Rajani Karuturi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=645516e ]
CLOUDSTACK-6531: stopping the router in case of command failures. Also added alerts for failures.
Signed-off-by: Jayapal <ja...@apache.org>
- ASF Subversion and Git Services
On May 5, 2014, 10:02 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20652/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 10:02 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-6531
> https://issues.apache.org/jira/browse/CLOUDSTACK-6531
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added a new configuration router.start.strict to optionally stop the router in case of command failures. Also added alerts for failures.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 80ca1cf
>
> Diff: https://reviews.apache.org/r/20652/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 20652: CLOUDSTACK-6531: VR alerts for command failures
during start and stop the router incase of failures
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/#review42288
-----------------------------------------------------------
Commit 59bf3559196a9452a1a048849f4f9971753d373b in cloudstack's branch refs/heads/master from Rajani Karuturi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=59bf355 ]
CLOUDSTACK-6531: stopping the router in case of command failures. Also added alerts for failures.
Signed-off-by: Jayapal <ja...@apache.org>
- ASF Subversion and Git Services
On May 5, 2014, 10:02 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20652/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 10:02 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-6531
> https://issues.apache.org/jira/browse/CLOUDSTACK-6531
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added a new configuration router.start.strict to optionally stop the router in case of command failures. Also added alerts for failures.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 80ca1cf
>
> Diff: https://reviews.apache.org/r/20652/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 20652: CLOUDSTACK-6531: VR alerts for command failures
during start and stop the router incase of failures
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/#review42293
-----------------------------------------------------------
Commit c081cf7b1ad7e45a228e7ad1fc62a428cff34d57 in cloudstack's branch refs/heads/4.4 from Rajani Karuturi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c081cf7 ]
CLOUDSTACK-6531: stopping the router in case of command failures. Also added alerts for failures.
Signed-off-by: Jayapal <ja...@apache.org>
- ASF Subversion and Git Services
On May 5, 2014, 10:02 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20652/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 10:02 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-6531
> https://issues.apache.org/jira/browse/CLOUDSTACK-6531
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added a new configuration router.start.strict to optionally stop the router in case of command failures. Also added alerts for failures.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 80ca1cf
>
> Diff: https://reviews.apache.org/r/20652/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 20652: CLOUDSTACK-6531: VR alerts for command failures
during start and stop the router incase of failures
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/
-----------------------------------------------------------
(Updated May 5, 2014, 10:02 a.m.)
Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
Bugs: CLOUDSTACK-6531
https://issues.apache.org/jira/browse/CLOUDSTACK-6531
Repository: cloudstack-git
Description
-------
added a new configuration router.start.strict to optionally stop the router in case of command failures. Also added alerts for failures.
Diffs (updated)
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 80ca1cf
Diff: https://reviews.apache.org/r/20652/diff/
Testing
-------
Manually tested.
Thanks,
Rajani Karuturi
Re: Review Request 20652: CLOUDSTACK-6531: VR alerts for command failures
during start and stop the router incase of failures
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/
-----------------------------------------------------------
(Updated May 5, 2014, 9:47 a.m.)
Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
Bugs: CLOUDSTACK-6531
https://issues.apache.org/jira/browse/CLOUDSTACK-6531
Repository: cloudstack-git
Description
-------
added a new configuration router.start.strict to optionally stop the router in case of command failures. Also added alerts for failures.
Diffs (updated)
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 80ca1cf
Diff: https://reviews.apache.org/r/20652/diff/
Testing
-------
Manually tested.
Thanks,
Rajani Karuturi
Re: Review Request 20652: CLOUDSTACK-6531: VR alerts for command failures
during start and stop the router incase of failures
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/
-----------------------------------------------------------
(Updated April 29, 2014, 9:09 a.m.)
Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
Summary (updated)
-----------------
CLOUDSTACK-6531: VR alerts for command failures during start and stop the router incase of failures
Bugs: CLOUDSTACK-6531
https://issues.apache.org/jira/browse/CLOUDSTACK-6531
Repository: cloudstack-git
Description
-------
added a new configuration router.start.strict to optionally stop the router in case of command failures. Also added alerts for failures.
Diffs
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 466b861
Diff: https://reviews.apache.org/r/20652/diff/
Testing
-------
Manually tested.
Thanks,
Rajani Karuturi
Re: Review Request 20652: VR alerts for command failures during start and
stop the router incase of failures
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/
-----------------------------------------------------------
(Updated April 28, 2014, 6:27 a.m.)
Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
Summary (updated)
-----------------
VR alerts for command failures during start and stop the router incase of failures
Repository: cloudstack-git
Description
-------
added a new configuration router.start.strict to optionally stop the router in case of command failures. Also added alerts for failures.
Diffs (updated)
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 466b861
Diff: https://reviews.apache.org/r/20652/diff/
Testing
-------
Manually tested.
Thanks,
Rajani Karuturi