[GitHub] [beam] yixiaoshen commented on a diff in pull request #23322: Support named databases in Firestore connector. Fix and enable Firestore IT test

[GitBox <gi...@apache.org>]

yixiaoshen commented on code in PR #23322:
URL: https://github.com/apache/beam/pull/23322#discussion_r984897447


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreOptions.java:
##########
@@ -45,4 +46,15 @@ public interface FirestoreOptions extends PipelineOptions {
    * @see com.google.cloud.firestore.FirestoreOptions.Builder#setEmulatorHost(java.lang.String)
    */
   void setEmulatorHost(String host);
+
+  /**
+   * The Firestore database ID to connect to. Note: named database is currently an internal feature
+   * in Firestore. Do not set this to anything other than "(default)".
+   */
+  @Description("Firestore database ID")
+  @Default.String("(default)")
+  String getFirestoreDb();

Review Comment:
   pcostell@ and I talked about this offline and decided to keep this option as firestoreDb to avoid ambiguity and conflict with other GCP service's connectors when specified from command line (e.g. Spanner uses databaseId option in their IT tests).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org