You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jonas (JIRA)" <ji...@apache.org> on 2007/09/03 10:55:19 UTC

[jira] Created: (WICKET-920) ExternalLink produces invalid html

ExternalLink produces invalid html
----------------------------------

                 Key: WICKET-920
                 URL: https://issues.apache.org/jira/browse/WICKET-920
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.0-beta3
         Environment: Wicket 1.3.0-beta3, Tomcat 5.5.20, Eclipse 3.3/WTP
            Reporter: Jonas
            Priority: Minor
         Attachments: test.zip

ExternalLink in Wicket 1.3.0-beta3 produces invalid html if PopupSettings without a page name is used.
In ExternalLink#onComponentTag the 'target' attribute is added even if the page map name is null, which
results in html output like this: 
<a href="http://www.google.com/" target>...</a>
(Note that the 'target' attribute doesn't have a value)
To ensure valid html output, it should also be checked if popupPageMap.getName() isn't null on line 203 of ExternalLink.
I've attached some code that illustrates the problem, and also shows a workaround.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-920) ExternalLink produces invalid html

Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerolf Seitz resolved WICKET-920.
---------------------------------

    Resolution: Fixed

fixed, thanks for raising this issue

> ExternalLink produces invalid html
> ----------------------------------
>
>                 Key: WICKET-920
>                 URL: https://issues.apache.org/jira/browse/WICKET-920
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>         Environment: Wicket 1.3.0-beta3, Tomcat 5.5.20, Eclipse 3.3/WTP
>            Reporter: Jonas
>            Assignee: Gerolf Seitz
>            Priority: Minor
>             Fix For: 1.3.0-rc1
>
>         Attachments: test.zip
>
>
> ExternalLink in Wicket 1.3.0-beta3 produces invalid html if PopupSettings without a page name is used.
> In ExternalLink#onComponentTag the 'target' attribute is added even if the page map name is null, which
> results in html output like this: 
> <a href="http://www.google.com/" target>...</a>
> (Note that the 'target' attribute doesn't have a value, which is invalid html according to validator.w3.org)
> To ensure valid html output, it should also be checked if popupPageMap.getName() isn't null on line 203 of ExternalLink.
> I've attached some code that illustrates the problem, and also shows a workaround.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-920) ExternalLink produces invalid html

Posted by "Jonas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonas updated WICKET-920:
-------------------------

    Description: 
ExternalLink in Wicket 1.3.0-beta3 produces invalid html if PopupSettings without a page name is used.
In ExternalLink#onComponentTag the 'target' attribute is added even if the page map name is null, which
results in html output like this: 
<a href="http://www.google.com/" target>...</a>
(Note that the 'target' attribute doesn't have a value, which is invalid html according to validator.w3.org)
To ensure valid html output, it should also be checked if popupPageMap.getName() isn't null on line 203 of ExternalLink.
I've attached some code that illustrates the problem, and also shows a workaround.

  was:
ExternalLink in Wicket 1.3.0-beta3 produces invalid html if PopupSettings without a page name is used.
In ExternalLink#onComponentTag the 'target' attribute is added even if the page map name is null, which
results in html output like this: 
<a href="http://www.google.com/" target>...</a>
(Note that the 'target' attribute doesn't have a value)
To ensure valid html output, it should also be checked if popupPageMap.getName() isn't null on line 203 of ExternalLink.
I've attached some code that illustrates the problem, and also shows a workaround.


> ExternalLink produces invalid html
> ----------------------------------
>
>                 Key: WICKET-920
>                 URL: https://issues.apache.org/jira/browse/WICKET-920
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>         Environment: Wicket 1.3.0-beta3, Tomcat 5.5.20, Eclipse 3.3/WTP
>            Reporter: Jonas
>            Priority: Minor
>         Attachments: test.zip
>
>
> ExternalLink in Wicket 1.3.0-beta3 produces invalid html if PopupSettings without a page name is used.
> In ExternalLink#onComponentTag the 'target' attribute is added even if the page map name is null, which
> results in html output like this: 
> <a href="http://www.google.com/" target>...</a>
> (Note that the 'target' attribute doesn't have a value, which is invalid html according to validator.w3.org)
> To ensure valid html output, it should also be checked if popupPageMap.getName() isn't null on line 203 of ExternalLink.
> I've attached some code that illustrates the problem, and also shows a workaround.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-920) ExternalLink produces invalid html

Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerolf Seitz reassigned WICKET-920:
-----------------------------------

    Assignee: Gerolf Seitz

> ExternalLink produces invalid html
> ----------------------------------
>
>                 Key: WICKET-920
>                 URL: https://issues.apache.org/jira/browse/WICKET-920
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>         Environment: Wicket 1.3.0-beta3, Tomcat 5.5.20, Eclipse 3.3/WTP
>            Reporter: Jonas
>            Assignee: Gerolf Seitz
>            Priority: Minor
>             Fix For: 1.3.0-rc1
>
>         Attachments: test.zip
>
>
> ExternalLink in Wicket 1.3.0-beta3 produces invalid html if PopupSettings without a page name is used.
> In ExternalLink#onComponentTag the 'target' attribute is added even if the page map name is null, which
> results in html output like this: 
> <a href="http://www.google.com/" target>...</a>
> (Note that the 'target' attribute doesn't have a value, which is invalid html according to validator.w3.org)
> To ensure valid html output, it should also be checked if popupPageMap.getName() isn't null on line 203 of ExternalLink.
> I've attached some code that illustrates the problem, and also shows a workaround.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-920) ExternalLink produces invalid html

Posted by "Jonas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonas updated WICKET-920:
-------------------------

    Attachment: test.zip

> ExternalLink produces invalid html
> ----------------------------------
>
>                 Key: WICKET-920
>                 URL: https://issues.apache.org/jira/browse/WICKET-920
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>         Environment: Wicket 1.3.0-beta3, Tomcat 5.5.20, Eclipse 3.3/WTP
>            Reporter: Jonas
>            Priority: Minor
>         Attachments: test.zip
>
>
> ExternalLink in Wicket 1.3.0-beta3 produces invalid html if PopupSettings without a page name is used.
> In ExternalLink#onComponentTag the 'target' attribute is added even if the page map name is null, which
> results in html output like this: 
> <a href="http://www.google.com/" target>...</a>
> (Note that the 'target' attribute doesn't have a value)
> To ensure valid html output, it should also be checked if popupPageMap.getName() isn't null on line 203 of ExternalLink.
> I've attached some code that illustrates the problem, and also shows a workaround.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.