You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by "Kriskras99 (via GitHub)" <gi...@apache.org> on 2026/03/05 13:09:24 UTC

Re: [PR] chore: Detect MSRV builds and run derive UI tests [avro-rs]

Kriskras99 commented on code in PR #504:
URL: https://github.com/apache/avro-rs/pull/504#discussion_r2889886999


##########
avro_derive/tests/ui.rs:
##########
@@ -18,7 +18,7 @@
 /// These tests only run on nightly as the output can change per compiler version.
 ///
 /// See <https://github.com/dtolnay/trybuild/issues/84>
-#[rustversion::attr(not(nightly), ignore)]
+#[cfg_attr(not(msrv), ignore)]

Review Comment:
   This does mean that a developer will have to install the MSRV to run the UI tests, I think it's more likely that developers will have nightly installed (or even enabled by default).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org