[jira] [Commented] (CLOUDSTACK-3152) addVmwareDc API call fails if called more than once to add same VMware DC to same cloudstack zone.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697711#comment-13697711 ] 

ASF subversion and git services commented on CLOUDSTACK-3152:
-------------------------------------------------------------

Commit 6aa9b2f35657612e4ef9444971f556d152da5f9a in branch refs/heads/master from [~sateeshc]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6aa9b2f ]

CLOUDSTACK-3152 addVmwareDc API call fails if called more than once to add same VMware DC to same cloudstack zone.

Check if the associated VMware DC matches the one specified in API params. This check would yield success as the association exists between same entities (zone and VMware DC)
This scenario would result in if the API addVmwareDc is called more than once with same parameters. For such scenario, return success response with VmwareDatacenter object read from database. Also returns success if addVmwareDC is called agsin with same zone and VMwareDC where the zone already has resources added to it (clusters etc.)

Signed-off-by: Sateesh Chodapuneedi <sa...@apache.org>

                
> addVmwareDc API call fails if called more than once to add same VMware DC to same cloudstack zone.
> --------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-3152
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3152
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VMware
>    Affects Versions: 4.2.0
>            Reporter: Sateesh Chodapuneedi
>            Assignee: Sateesh Chodapuneedi
>
> This can be fixed by making addVmwareDC API return success if it is detected that VMware DC and Cloudstack zone specified in paramters are already associated with each other.
> Add cluster page of zone wizard calls 2 APIs.
> 1) addVmwareDc
> 2) addCluster
> If call to addVmwareDc succeeds then UI proceeds to make a call to addCluster. If this call fails then "Fix errors" takes user to addCluster page of zone wizard again.
> Again UI calls both the APIs. But this time addVmwareDc returns failure saying 
> "Something went wrong; please correct the following: Zone 1 is already associated with a VMware datacenter.". If we goto "Fix errors" the process continues and user will be stuck in infinite loop.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira