You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Dhaval Shah <dh...@gmail.com> on 2022/04/05 07:26:23 UTC

Re: Review Request 73621: RANGER-3442: Fix Ranger KMS DAO memory issues when creating many new keys

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73621/#review224247
-----------------------------------------------------------


Ship it!




Ship It!

- Dhaval Shah


On Sept. 30, 2021, 8:18 p.m., Pavi Subenderan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73621/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2021, 8:18 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-3442
>     https://issues.apache.org/jira/browse/RANGER-3442
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Clear the EntityManager after getting keys to reduce memory pressure. See ticket RANGER-3442 for more details.
> 
> 
> Diffs
> -----
> 
>   kms/src/main/java/org/apache/ranger/kms/dao/BaseDao.java b32d130 
> 
> 
> Diff: https://reviews.apache.org/r/73621/diff/1/
> 
> 
> Testing
> -------
> 
> Ran this patch in our cluster and created hundreds of keys with no noticeable memory increase. 
> Previously without this patch, we would hit memory limit very quickly when creating keys. This memory usage would not go down after.
> This patch has been running for almost a week in our cluster with no regressions or memory issues.
> 
> 
> Thanks,
> 
> Pavi Subenderan
> 
>