You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/26 17:34:51 UTC
[GitHub] [superset] nytai commented on a change in pull request #13276: test: ErrorBoundary dedicated directory and tests
nytai commented on a change in pull request #13276:
URL: https://github.com/apache/superset/pull/13276#discussion_r583803657
##########
File path: superset-frontend/src/components/ErrorBoundary/index.jsx
##########
@@ -19,7 +19,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import { t } from '@superset-ui/core';
-import ErrorMessageWithStackTrace from './ErrorMessage/ErrorMessageWithStackTrace';
+import ErrorMessageWithStackTrace from '../ErrorMessage/ErrorMessageWithStackTrace';
Review comment:
nit: prefer absolute import unless it's `./`
##########
File path: superset-frontend/src/components/ErrorBoundary/index.jsx
##########
@@ -19,7 +19,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import { t } from '@superset-ui/core';
-import ErrorMessageWithStackTrace from './ErrorMessage/ErrorMessageWithStackTrace';
+import ErrorMessageWithStackTrace from '../ErrorMessage/ErrorMessageWithStackTrace';
Review comment:
nit: prefer absolute import unless it's `./`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org