[GitHub] [druid] imply-elliott commented on a diff in pull request #14031: Clean docker environment before Revised ITs test in GHA

["imply-elliott (via GitHub)" <gi...@apache.org>]

imply-elliott commented on code in PR #14031:
URL: https://github.com/apache/druid/pull/14031#discussion_r1158810493


##########
.github/workflows/reusable-revised-its.yml:
##########
@@ -117,8 +117,11 @@ jobs:
           echo $DRUID_IT_IMAGE_NAME
           docker save "$DRUID_IT_IMAGE_NAME" | gzip > druid-container-jdk${{ inputs.build_jdk }}.tar.gz
 
-      - name: Load docker image
+      - name: Clean docker environment and Load docker image
         run: |
+          echo "Stopping and pruning any remnant docker containers from previous run"
+          docker ps -aq | xargs -r docker rm -f
+          docker system prune -af --volumes

Review Comment:
   I had a PR open for this here: https://github.com/apache/druid/pull/13940
   If you read Paul's comment here https://github.com/apache/druid/pull/13940/files#r1139411707, he feels the same way.  I agree, it should probably be rolled in.  It's also less heavy handed than this, since this removes ALL containers on the runner, which includes some pre-cached ones that save a little time.  Honestly though, they're not that useful for us and the cleanup is very brief, so I didn't put much weight on being less heavy handed for the older ITs, given they're not long for the world.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org