You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/02/06 20:21:12 UTC
[jira] Created: (HBASE-419) Move RegionServer and related classes
into regionserver package
Move RegionServer and related classes into regionserver package
---------------------------------------------------------------
Key: HBASE-419
URL: https://issues.apache.org/jira/browse/HBASE-419
Project: Hadoop HBase
Issue Type: Sub-task
Reporter: Bryan Duxbury
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571798#action_12571798 ]
stack commented on HBASE-419:
-----------------------------
Patch failed to apply to TRUNK:
{code}
patching file src/test/org/apache/hadoop/hbase/TestScannerAPI.java
Hunk #1 FAILED at 30.
1 out of 1 hunk FAILED -- saving rejects to file src/test/org/apache/hadoop/hbase/TestScannerAPI.java.rej
{code}
Patch mostly all class moves. Changes don't show because of class moves. I'd say for this issue, keep the moves to the maximum and minimize how much you change the actual classes. Fix the above failed patch application and just apply it.
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 419.patch
>
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned HBASE-419:
-----------------------------------
Assignee: Bryan Duxbury
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-419:
--------------------------------
Status: Patch Available (was: Open)
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 419.patch
>
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571854#action_12571854 ]
stack commented on HBASE-419:
-----------------------------
I like jim's comments.
+1 on idea of making a package for log (I'd suggest log rather than hlog).... .
Should store be subpackage of regionserver rather than a peer?
+1 on moving HRegionInterface etc. into ipc package.
+1 on HSK being at top level rather than under regionmanager
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 419.patch
>
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-419:
--------------------------------
Attachment: 419.patch
This patch moves all the classes and tests, adds needed imports all over the place, and makes some previously package-access methods public, mostly for the sake of tests. All unit tests pass locally. Please review.
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 419.patch
>
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571855#action_12571855 ]
stack commented on HBASE-419:
-----------------------------
We should just do the Jim suggestions in a new issue? If you ain't doing it Bryan, give it to me and I'll do it. Good stuff.
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 419.patch
>
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-419:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this, per Stack's suggestion. (Should have checked the issue again and seen Jim's comments...) I will address javadoc issues in the new issue Jim created.
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 419.patch
>
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571864#action_12571864 ]
Jim Kellerman commented on HBASE-419:
-------------------------------------
> Should store be subpackage of regionserver rather than a peer?
Both master.BaseScanner and util.Migrate use HStore.isReference but that is already public, so where it lives is not that important I guess.
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 419.patch
>
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-419:
--------------------------------
Priority: Minor (was: Major)
Description:
Move:
* HRegionServer
* HRegionInterface
* HRegion
* HStore
* HStoreFile
* HInternalScannerInterface ?
* HStoreKey
Others?
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Priority: Minor
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571807#action_12571807 ]
Jim Kellerman commented on HBASE-419:
-------------------------------------
Do the constructors for ProcessRegionXxx need to be public? Shouldn't they be package scoped?
You didn't move HScannerInterface, Leases or HMsg because they are used in multiple places.
Why move:
- HRegionInterface (used by master and client)
- HMasterInterface (used by master and client)
- HMasterRegionInterface (used by master and region server)
- HStoreKey (used almost everywhere)
If I were going to move everything, I might do something like:
- put HLog, HLogKey, HLogEdit, LogRollListener into o.a.h.h.hlog
- put HStore, HStoreKey, HStoreFile, HStoreSize into o.a.h.h.hstore
- put HRegionInterface, HMasterInterface and HMasterRegionInterface into o.a.h.h.ipc
javadoc warnings: (must be fixed)
[javadoc] C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\mapred\GroupingTableMap.java:91: warning - Tag @see: can't find map(org.apache.hadoop.hbase.HStoreKey, org.apache.hadoop.io.MapWritable, org.apache.hadoop.mapred.OutputCollector, org.apache.hadoop.mapred.Reporter) in org.apache.hadoop.hbase.mapred.TableMap
[javadoc] C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\mapred\IdentityTableMap.java:47: warning - Tag @see: can't find map(org.apache.hadoop.hbase.HStoreKey, org.apache.hadoop.io.MapWritable, org.apache.hadoop.mapred.OutputCollector, org.apache.hadoop.mapred.Reporter) in org.apache.hadoop.hbase.mapred.TableMap
[javadoc] C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\mapred\TableInputFormat.java:58: warning - Tag @see: reference not found: org.apache.hadoop.hbase.HAbstractScanner for column name wildcards
[javadoc] C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\regionserver\HAbstractScanner.java:205: warning - Tag @see: can't find next(org.apache.hadoop.hbase.HStoreKey, java.util.SortedMap) in org.apache.hadoop.hbase.HScannerInterface
[javadoc] C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\regionserver\HRegion.java:713: warning - @return tag has no arguments.
[javadoc] C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\regionserver\HRegionServer.java:993: warning - Tag @link: reference not found: Flusher
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 419.patch
>
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-419) Move RegionServer and related classes
into regionserver package
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HBASE-419:
--------------------------------
Fix Version/s: 0.2.0
Affects Version/s: 0.2.0
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 419.patch
>
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.