You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/02/15 00:40:25 UTC
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6008
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
IMPALA-3405: [DOCS] Pare down upgrading section
Physically remove the CM upgrading instructions
and the yum, zypper, apt-get procedure too.
Replace with a reference to rebuilding and redeploying,
via instructions on the Apache Impala wiki.
Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
---
M docs/topics/impala_upgrading.xml
1 file changed, 7 insertions(+), 347 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/6008/1
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6008/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
Line 278
Can you file a bug against Apache Impala to get these working again?
Line 49: <xref href="https://cwiki.apache.org/confluence/display/IMPALA/Building+Impala" scope="external" format="html">build procedure on the Apache Impala wiki</xref>.
I'd point to README.md. Also, this line is very long.
PS1, Line 50: start-impala-cluster.py
Does anyone do this for anything except their test minicluster?
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
IMPALA-3405: [DOCS] Pare down upgrading section
Physically remove the CM upgrading instructions
and the yum, zypper, apt-get procedure too.
Replace with a reference to rebuilding and redeploying,
via instructions on the Apache Impala wiki.
Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Reviewed-on: http://gerrit.cloudera.org:8080/6008
Tested-by: Impala Public Jenkins
Reviewed-by: John Russell <jr...@cloudera.com>
---
M docs/topics/impala_upgrading.xml
1 file changed, 24 insertions(+), 278 deletions(-)
Approvals:
Impala Public Jenkins: Verified
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 5:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/71/
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6008/3/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
Line 388
Is this no longer valid?
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 5:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/72/
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 5: Code-Review+2
Doh. The blue button with "Code-Review+2" keeps making me think the review has already been +2'ed.
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Laurel Hale, Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6008
to look at the new patch set (#5).
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
IMPALA-3405: [DOCS] Pare down upgrading section
Physically remove the CM upgrading instructions
and the yum, zypper, apt-get procedure too.
Replace with a reference to rebuilding and redeploying,
via instructions on the Apache Impala wiki.
Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
---
M docs/topics/impala_upgrading.xml
1 file changed, 24 insertions(+), 278 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/6008/5
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
IMPALA-3405: [DOCS] Pare down upgrading section
Physically remove the CM upgrading instructions
and the yum, zypper, apt-get procedure too.
Replace with a reference to rebuilding and redeploying,
via instructions on the Apache Impala wiki.
Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
---
M docs/topics/impala_upgrading.xml
1 file changed, 24 insertions(+), 285 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/6008/3
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
IMPALA-3405: [DOCS] Pare down upgrading section
Physically remove the CM upgrading instructions
and the yum, zypper, apt-get procedure too.
Replace with a reference to rebuilding and redeploying,
via instructions on the Apache Impala wiki.
Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
---
M docs/topics/impala_upgrading.xml
1 file changed, 18 insertions(+), 334 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/6008/2
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 4:
(1 comment)
Fixed typo. I'll turn the +1 into +2 momentarily.
http://gerrit.cloudera.org:8080/#/c/6008/4/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
PS4, Line 80: host
> should be "hosts"
Done
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 1:
There is a merge conflict and after resolving it, the rendered file includes the full last line "To upgrade Impala, run these Linux commands on the appropriate hosts in your cluster:" According to the changes I see in gerrit, you removed then colon at the end of that sentence so perhaps my resolution of the merge conflict was not correct. Please remove the merge conflict so I can review the rendered file as you intend it. Otherwise, built without errors.
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 3:
(5 comments)
I think this info is now a reasonable compromise between removing vendor-specific info but keeping the necessary details to make it useful for a user of the open source project.
http://gerrit.cloudera.org:8080/#/c/6008/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
Line 49: <p>
> I'd point to README.md. Also, this line is very long.
Done
Line 49: <p>
> This comment has not been addressed.
Done
PS1, Line 50:
> Does anyone do this for anything except their test minicluster?
Done
PS1, Line 50:
> I do not know, this is not something I engage in. Who wrote the original su
That would have been me, way back in the day, using a single-node VM. Let's take it as a given that those original "manual" instructions are sufficient, except for the part about downloading new packages, and I'll restore that portion of the instructions.
PS1, Line 50:
> No idea. If this is not the appropriate procedure, what is? Should I bring
Done
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Builds cleanly, looks good, except for one small typo described below.
http://gerrit.cloudera.org:8080/#/c/6008/4/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
PS4, Line 80: host
should be "hosts"
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6008/3/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
Line 388
> Is this no longer valid?
Done. Good point, I believed a long time ago that someone was going to improve this error handling but I don't know if that ever happened. I'll restore the note.
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 2:
(2 comments)
I amended the instructions in a hand-wavey kind of way because I haven't performed or witnessed this procedure myself using Apache Impala on a multi-node cluster. So perhaps there are more details to bring back from the original instructions but I can't confirm that myself.
Laurel re: build conflict. I had to do some conflict resolution but you should be able to skip that during your build testing. Do the 'checkout' commands under the Download dropdown and you can be exactly the source corresponding to this gerrit review.
http://gerrit.cloudera.org:8080/#/c/6008/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
Line 278
> Can you file a bug against Apache Impala to get these working again?
I'm not aware of the situation of these working or not working, so I'm not in a good position to vouch for or verify such a bug. Can I ask you to do that if you have the details?
PS1, Line 50:
> Does anyone do this for anything except their test minicluster?
No idea. If this is not the appropriate procedure, what is? Should I bring back the 'sudo service ... start' steps from before?
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 5:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/70/
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6008/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
Line 278
> I'm not aware of the situation of these working or not working, so I'm not
I do not have the details. I assumed you removed them because you knew they were wrong.
This patch should probably not be submitted until we have someone who knows how to do this vet this change.
Line 49: <xref href="https://cwiki.apache.org/confluence/display/IMPALA/Building+Impala" scope="external" format="html">build procedure on the Apache Impala wiki</xref>.
> I'd point to README.md. Also, this line is very long.
This comment has not been addressed.
PS1, Line 50: start-impala-cluster.py
> No idea. If this is not the appropriate procedure, what is? Should I bring
I do not know, this is not something I engage in. Who wrote the original sudo service lines - do they know?
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#4).
Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................
IMPALA-3405: [DOCS] Pare down upgrading section
Physically remove the CM upgrading instructions
and the yum, zypper, apt-get procedure too.
Replace with a reference to rebuilding and redeploying,
via instructions on the Apache Impala wiki.
Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
---
M docs/topics/impala_upgrading.xml
1 file changed, 24 insertions(+), 278 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/6008/4
--
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>