You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Murali Reddy <Mu...@citrix.com> on 2013/03/20 02:45:19 UTC
[MERGE] GSLB
I would like to merge GSLB feature proposed [1] and developed in the feature branch [2] into master. Code for this feature pretty much conforms to what was proposed in FS [3]. I added unit tests for all the new service layer methods introduced[4]. I have made the patch available at [5], if any one wish to review please do so.
This functionality is completely isolated and code path is not hit unless GSLB functionality is used.
[1] http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201301.mbox/%3CCD1281EE.2B118%25murali.reddy@citrix.com%3E
[2] https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=shortlog;h=refs/heads/gslb-wip
[3] https://cwiki.apache.org/confluence/display/CLOUDSTACK/GSLB+(Global+Server+Load+Balancing)+Functional+specification+and+Design+Document
[4] https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=blob;f=server/test/org/apache/cloudstack/region/gslb/GlobalLoadBalancingRulesServiceImplTest.java;h=cea4fd9324b232ad2de92954b9693e2fc6ac4bc1;hb=refs/heads/gslb-wip
[5] https://reviews.apache.org/r/10021/
-Murali
Re: [MERGE] GSLB
Posted by Chip Childers <ch...@sungard.com>.
On Wed, Mar 20, 2013 at 01:45:19AM +0000, Murali Reddy wrote:
> I would like to merge GSLB feature proposed [1] and developed in the feature branch [2] into master. Code for this feature pretty much conforms to what was proposed in FS [3]. I added unit tests for all the new service layer methods introduced[4]. I have made the patch available at [5], if any one wish to review please do so.
>
> This functionality is completely isolated and code path is not hit unless GSLB functionality is used.
>
> [1] http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201301.mbox/%3CCD1281EE.2B118%25murali.reddy@citrix.com%3E
> [2] https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=shortlog;h=refs/heads/gslb-wip
> [3] https://cwiki.apache.org/confluence/display/CLOUDSTACK/GSLB+(Global+Server+Load+Balancing)+Functional+specification+and+Design+Document
> [4] https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=blob;f=server/test/org/apache/cloudstack/region/gslb/GlobalLoadBalancingRulesServiceImplTest.java;h=cea4fd9324b232ad2de92954b9693e2fc6ac4bc1;hb=refs/heads/gslb-wip
> [5] https://reviews.apache.org/r/10021/
>
> -Murali
>
I'm +1 for this, with one qualification. The patch doesn't actually
apply to master. That being said, I appreciate you providing a single
patch for *review* purposes. The mechanics of merging from your feature
branch don't have to go through reviewboard, so the actual application
of the patch is unimportant to me (assuming you check the build, RAT,
etc... prior to pushing your merge result).
Murali - thank you for taking the time to provide such a good MERGE
email!
-chip
Re: [MERGE] GSLB
Posted by murali reddy <mu...@gmail.com>.
On Wed, Mar 27, 2013 at 7:26 PM, Chip Childers <ch...@sungard.com>wrote:
> On Wed, Mar 27, 2013 at 01:08:58PM +0000, Murali Reddy wrote:
> > On 20/03/13 7:15 AM, "Murali Reddy" <Mu...@citrix.com> wrote:
> >
> > I merged this feature into master with below commit. All review comments
> > were addressed except one, I will open a bug for it.
>
> Which comment?
>
>
This comment "It will be good to have the zone names (site info) be listed
as part of the ListGSLB" from Vijay [1].
[1] https://reviews.apache.org/r/10021/
Re: [MERGE] GSLB
Posted by Chip Childers <ch...@sungard.com>.
On Wed, Mar 27, 2013 at 01:08:58PM +0000, Murali Reddy wrote:
> On 20/03/13 7:15 AM, "Murali Reddy" <Mu...@citrix.com> wrote:
>
> >I would like to merge GSLB feature proposed [1] and developed in the
> >feature branch [2] into master. Code for this feature pretty much
> >conforms to what was proposed in FS [3]. I added unit tests for all the
> >new service layer methods introduced[4]. I have made the patch available
> >at [5], if any one wish to review please do so.
> >
> >This functionality is completely isolated and code path is not hit unless
> >GSLB functionality is used.
> >
> >[1]
> >http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201301.m
> >box/%3CCD1281EE.2B118%25murali.reddy@citrix.com%3E
> >[2]
> >https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=short
> >log;h=refs/heads/gslb-wip
> >[3]
> >https://cwiki.apache.org/confluence/display/CLOUDSTACK/GSLB+(Global+Server
> >+Load+Balancing)+Functional+specification+and+Design+Document
> >[4]
> >https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=blob;
> >f=server/test/org/apache/cloudstack/region/gslb/GlobalLoadBalancingRulesSe
> >rviceImplTest.java;h=cea4fd9324b232ad2de92954b9693e2fc6ac4bc1;hb=refs/head
> >s/gslb-wip
> >[5] https://reviews.apache.org/r/10021/
> >
> >-Murali
> >
> >
>
> I merged this feature into master with below commit. All review comments
> were addressed except one, I will open a bug for it.
Which comment?
>
> commit c5fb8349bf92b48bca6d06370112f5ec04a9d098
> Author: Murali Reddy <mu...@citrix.com>
> Date: Wed Mar 27 17:54:07 2013 +0530
>
> CLOUDSTACK-653 : High Availability: implement GSLB (Global Server Load
> Balancing) capability for ELB service merging GSLB feature
>
>
Re: [MERGE] GSLB
Posted by Murali Reddy <Mu...@citrix.com>.
On 20/03/13 7:15 AM, "Murali Reddy" <Mu...@citrix.com> wrote:
>I would like to merge GSLB feature proposed [1] and developed in the
>feature branch [2] into master. Code for this feature pretty much
>conforms to what was proposed in FS [3]. I added unit tests for all the
>new service layer methods introduced[4]. I have made the patch available
>at [5], if any one wish to review please do so.
>
>This functionality is completely isolated and code path is not hit unless
>GSLB functionality is used.
>
>[1]
>http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201301.m
>box/%3CCD1281EE.2B118%25murali.reddy@citrix.com%3E
>[2]
>https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=short
>log;h=refs/heads/gslb-wip
>[3]
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/GSLB+(Global+Server
>+Load+Balancing)+Functional+specification+and+Design+Document
>[4]
>https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=blob;
>f=server/test/org/apache/cloudstack/region/gslb/GlobalLoadBalancingRulesSe
>rviceImplTest.java;h=cea4fd9324b232ad2de92954b9693e2fc6ac4bc1;hb=refs/head
>s/gslb-wip
>[5] https://reviews.apache.org/r/10021/
>
>-Murali
>
>
I merged this feature into master with below commit. All review comments
were addressed except one, I will open a bug for it.
commit c5fb8349bf92b48bca6d06370112f5ec04a9d098
Author: Murali Reddy <mu...@citrix.com>
Date: Wed Mar 27 17:54:07 2013 +0530
CLOUDSTACK-653 : High Availability: implement GSLB (Global Server Load
Balancing) capability for ELB service merging GSLB feature