You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2023/04/07 14:43:38 UTC

[GitHub] [flink] reswqa commented on a diff in pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

reswqa commented on code in PR #22207:
URL: https://github.com/apache/flink/pull/22207#discussion_r1160743167


##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -1945,8 +1938,4 @@ Map<String, String> generateApplicationMasterEnv(
         Utils.setupYarnClassPath(this.yarnConfiguration, env);
         return env;
     }
-
-    private String getDisplayMemory(long memoryMB) {

Review Comment:
   Even if we use a long value, converting to byte here will still overflow, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org