You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Andrew Lamb (Jira)" <ji...@apache.org> on 2021/03/18 13:43:00 UTC
[ https://issues.apache.org/jira/browse/ARROW-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Lamb resolved ARROW-10903.
---------------------------------
Fix Version/s: 4.0.0
Resolution: Fixed
Issue resolved by pull request 9647
[https://github.com/apache/arrow/pull/9647]
> [Rust] Implement FromIter<Option<Vec<u8>>> constructor for FixedSizeBinaryArray
> -------------------------------------------------------------------------------
>
> Key: ARROW-10903
> URL: https://issues.apache.org/jira/browse/ARROW-10903
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Rust
> Reporter: Andrew Lamb
> Assignee: Ivan Vankov
> Priority: Minor
> Labels: beginner, beginner-friendly, pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Context: https://github.com/apache/arrow/pull/8853#discussion_r542189448 suggestion by [~jorgecarleitao]
> Basically, the goal would be to remove
> {code}
> impl From<Vec<Option<Vec<u8>>>> for FixedSizeBinaryArray {
> {code}
> Which while mostly used in tests, panics in certain situations.
> Goal would be to replace that implementation with a `FromIter` implementation which is more performance, more general, and has the same ergonomics (from(vec![].into_iter()) instead of from(vec![...]) for a vector).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)