[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

[GitBox <gi...@apache.org>]

dstandish commented on code in PR #27758:
URL: https://github.com/apache/airflow/pull/27758#discussion_r1058818076


##########
airflow/models/taskinstance.py:
##########
@@ -547,7 +547,7 @@ def try_number(self):
         database, in all other cases this will be incremented.
         """
         # This is designed so that task logs end up in the right file.
-        if self.state in State.running:
+        if self.state == State.RUNNING:

Review Comment:
   @ashb i think this resolves the "log to wrong file" problem.
   
   when state is deferred, try number is decremented. so we need the plus one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org