You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by luojiangyu <gi...@git.apache.org> on 2018/07/24 04:02:46 UTC
[GitHub] flink pull request #6400: [FLINK-9931][ui] watermark display bug.
GitHub user luojiangyu opened a pull request:
https://github.com/apache/flink/pull/6400
[FLINK-9931][ui] watermark display bug.
If the parallelism of the operator is bigger, the request url of watermark may access the limit of the length of http url, it results in watermark display bug.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/luojiangyu/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6400
----
commit 2db2afe4b31ca74345735876694590033cfea3b3
Author: luojiangyu <lu...@...>
Date: 2018-07-24T03:56:51Z
[FLINK-9931][ui] watermark display bug.
----
---
[GitHub] flink issue #6400: [FLINK-9931][ui] watermark display bug.
Posted by luojiangyu <gi...@git.apache.org>.
Github user luojiangyu commented on the issue:
https://github.com/apache/flink/pull/6400
the code is modified using a similar http approach as the metric aggregation. please help me review the PR.
---
[GitHub] flink pull request #6400: [FLINK-9931][ui] watermark display bug.
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6400#discussion_r204757730
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobVertexMetricsHandler.java ---
@@ -57,4 +70,77 @@ public JobVertexMetricsHandler(Executor executor, MetricFetcher fetcher) {
? task.metrics
: null;
}
+
+ @Override
+ protected String getRequestMetricsList(Map<String, String> queryParams) {
+ String metricRequestsList = queryParams.get(PARAMETER_METRICS);
+ String subtasksList = queryParams.get(SUB_TASKS);
+ if (subtasksList == null || subtasksList.isEmpty()) {
+ return queryParams.get(PARAMETER_METRICS);
--- End diff --
return `super.getRequestMetricsList(queryParams)` instead
---
[GitHub] flink issue #6400: [FLINK-9931][ui] watermark display bug.
Posted by luojiangyu <gi...@git.apache.org>.
Github user luojiangyu commented on the issue:
https://github.com/apache/flink/pull/6400
I know that the legacy handler will be de removed, but in the production, if the parallelism of the operator is bigger, it is diffculty to track the watermark problem by the flink ui.
---
[GitHub] flink pull request #6400: [FLINK-9931][ui] watermark display bug.
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6400#discussion_r204758822
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobVertexMetricsHandler.java ---
@@ -28,15 +35,21 @@
* {@code {"available": [ { "name" : "X", "id" : "X" } ] } }
*
* <p>If the query parameters do contain a "get" parameter, a comma-separated list of metric names is expected as a value.
- * {@code /metrics?get=X,Y}
+ * {@code /metrics?get=X,Y OR /metrics?get=X,Y&&subtasks=0-4,7-10}
* The handler will then return a list containing the values of the requested metrics.
* {@code [ { "id" : "X", "value" : "S" }, { "id" : "Y", "value" : "T" } ] }
*
* @deprecated This class is subsumed by {@link SubtaskMetricsHandler} and is only kept for backwards-compatibility.
*/
@Deprecated
public class JobVertexMetricsHandler extends AbstractMetricsHandler {
+ private final Logger log = LoggerFactory.getLogger(getClass());
--- End diff --
either add this as a protected field to the `AbstractMetricsHandler`, or change it to being static.
---
[GitHub] flink pull request #6400: [FLINK-9931][ui] watermark display bug.
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6400#discussion_r204759313
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobVertexMetricsHandler.java ---
@@ -28,15 +35,21 @@
* {@code {"available": [ { "name" : "X", "id" : "X" } ] } }
*
* <p>If the query parameters do contain a "get" parameter, a comma-separated list of metric names is expected as a value.
- * {@code /metrics?get=X,Y}
+ * {@code /metrics?get=X,Y OR /metrics?get=X,Y&&subtasks=0-4,7-10}
--- End diff --
should only be a single `&`
---