You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xuxin930 (via GitHub)" <gi...@apache.org> on 2024/03/11 13:25:49 UTC
[PR] cmake: fix libxx header file search path issue and enable libxx for CMake build [nuttx]
xuxin930 opened a new pull request, #11893:
URL: https://github.com/apache/nuttx/pull/11893
## Summary
In the original Makefile, we have `ARCHCXXFLAG` and `ARCHCFLAG` to distinguish the header file search paths of cxx files and c files.
However, in the CMake `target_include_directory`, the target language **_CANNOT_** be distinguished by default.
this causes the wrong header file search order.
What I want to do is separate the header file references of the c++ standard library by language just like Makefile base.
```cmake
# In c++ standard library: export header
set_property(
TARGET nuttx
APPEND
PROPERTY NUTTX_CXX_INCLUDE_DIRECTORIES ${CMAKE_BINARY_DIR}/include/libcxx)
# In target add_library_internal: automatically reference according to language
target_include_directories(
${target}
PRIVATE
$<$<COMPILE_LANGUAGE:CXX>:$<GENEX_EVAL:$<TARGET_PROPERTY:nuttx,NUTTX_CXX_INCLUDE_DIRECTORIES>>>
)
```
---
and also fix several typo
## Impact
libxx CMake build
## Testing
CI build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: fix libxx header file search path issue and enable libxx for CMake build [nuttx]
Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 commented on PR #11893:
URL: https://github.com/apache/nuttx/pull/11893#issuecomment-1991249693
CI failed because `matter` needs to be adapted
im working on it, and plan to open CMake's libxx CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: fix libxx header file search path issue and enable libxx for CMake build [nuttx]
Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 commented on PR #11893:
URL: https://github.com/apache/nuttx/pull/11893#issuecomment-1997065657
this change and https://github.com/apache/nuttx-apps/pull/2330 depend on each other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: fix libxx header file search path issue and enable libxx for CMake build [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #11893:
URL: https://github.com/apache/nuttx/pull/11893#issuecomment-1997977574
> this change and [apache/nuttx-apps#2330](https://github.com/apache/nuttx-apps/pull/2330) depend on each other @xiaoxiang781216 Do I need to temporarily turn off sim:matter?
Don't need, let me merge both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: fix libxx header file search path issue and enable libxx for CMake build [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 closed pull request #11893: cmake: fix libxx header file search path issue and enable libxx for CMake build
URL: https://github.com/apache/nuttx/pull/11893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: fix libxx header file search path issue and enable libxx for CMake build [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #11893:
URL: https://github.com/apache/nuttx/pull/11893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org