[GitHub] [arrow-rs] framlog commented on a diff in pull request #4003: feat: support to read/write customized metadata in ipc files

["framlog (via GitHub)" <gi...@apache.org>]

framlog commented on code in PR #4003:
URL: https://github.com/apache/arrow-rs/pull/4003#discussion_r1155826512


##########
arrow-ipc/src/writer.rs:
##########
@@ -798,13 +805,24 @@ impl<W: Write> FileWriter<W> {
         let dictionaries = fbb.create_vector(&self.dictionary_blocks);
         let record_batches = fbb.create_vector(&self.record_blocks);
         let schema = crate::convert::schema_to_fb_offset(&mut fbb, &self.schema);
+        let fb_custom_metadata = if !self.custom_metadata.is_empty() {

Review Comment:
   OK. I switched to that way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org