[GitHub] [pulsar] eolivelli commented on issue #12087: PIP 96: Payload processor for Pulsar client

[GitBox <gi...@apache.org>]

eolivelli commented on issue #12087:
URL: https://github.com/apache/pulsar/issues/12087#issuecomment-930299033


   catching `Throwable` is not good, we should not ask to the PayloadProcessor developer to do this.
   
   Why not change the signature to 
   ```
   public <T> void process(MessagePayload payload,
                                   EntryContext context,
                                   Schema<T> schema,
                                   Consumer<Message<T>> messageConsumer) throws Exception
   ```
   
   then we deal with catching any Throwable in Pulsar code ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org