You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/01/24 04:47:00 UTC
Review Request 30243: AMBARI-8317 Refactor the OS-dependent Ambari
Server Windows components - Part 2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30243/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
Bugs: AMBARI-8317
https://issues.apache.org/jira/browse/AMBARI-8317
Repository: ambari
Description
-------
+Moved LDAP and HTTPS setup routines away from ambari-server.py
+Merged ambari-server-windows.py into ambari-server.py, leaving out only the Windows service wrapper and the server start routine
Diffs
-----
ambari-server/pom.xml e01375f70beff6464a2a8e30fcb4a5efd0845874
ambari-server/src/main/assemblies/server-windows.xml 68e3a4e17ff76b7ea4fd8cdf1a5eb4c1672cd505
ambari-server/src/main/python/ambari-server-windows.py b4d4878d714ef1f18385c685fbab588c6642f976
ambari-server/src/main/python/ambari-server.py f67d697e344fe6148d2fd1957189f863d2eb8729
ambari-server/src/main/python/ambari_server/dbConfiguration.py 74bf1945c2b9303816b66353e7c987c40e615eda
ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 04dbb61eba13a988ee5b2f9b9136dc974488b4a2
ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 58fa7c4ce3960fb2c4243cd1b4ad12b9f9cec585
ambari-server/src/main/python/ambari_server/serverConfiguration.py 6b3f3507e1418c16633f8b0f02bc2ed9f47a355b
ambari-server/src/main/python/ambari_server/serverSetup.py b012fc41114cd1f94336ee1186cb077d912be224
ambari-server/src/main/python/ambari_server/serverUpgrade.py 1d9735ab34151136ae4d1190259ad2680a341315
ambari-server/src/main/python/ambari_server/serverUtils.py PRE-CREATION
ambari-server/src/main/python/ambari_server/setupActions.py 5ca5cce1d6494c3f04399c8706818ac5ab651737
ambari-server/src/main/python/ambari_server/setupHttps.py PRE-CREATION
ambari-server/src/main/python/ambari_server/setupSecurity.py 769b5f7aa5c4ac44e638175f34133b5232697d5c
ambari-server/src/main/python/ambari_server/userInput.py c15d335a50d48430cd7598f31d50a4ded88509ad
ambari-server/src/main/python/ambari_server_main.py PRE-CREATION
ambari-server/src/main/python/ambari_windows_service.py PRE-CREATION
ambari-server/src/main/windows/ambari-server.ps1 9afb341b216f4ca3a99fcb88fb21cf1775385b5c
ambari-server/src/test/python/TestAmbariServer.py d11e4feedce3fa11099336cb018c9a59e880dd02
Diff: https://reviews.apache.org/r/30243/diff/
Testing
-------
Thanks,
Florian Barca
Re: Review Request 30243: AMBARI-8317 Refactor the OS-dependent Ambari
Server Windows components - Part 2
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30243/#review69528
-----------------------------------------------------------
ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py
<https://reviews.apache.org/r/30243/#comment114224>
Why do we need a different default windows username password for the database? Why cant we keep the default for Windows and Linux the same? I would rather prefer that to be the consistent.
- Jayush Luniya
On Jan. 24, 2015, 3:49 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30243/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2015, 3:49 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
>
>
> Bugs: AMBARI-8317
> https://issues.apache.org/jira/browse/AMBARI-8317
>
>
> Repository: ambari
>
>
> Description
> -------
>
> +Moved LDAP and HTTPS setup routines away from ambari-server.py
> +Merged ambari-server-windows.py into ambari-server.py, leaving out only the Windows service wrapper and the server start routine
>
>
> Diffs
> -----
>
> ambari-server/pom.xml e01375f70beff6464a2a8e30fcb4a5efd0845874
> ambari-server/src/main/assemblies/server-windows.xml 68e3a4e17ff76b7ea4fd8cdf1a5eb4c1672cd505
> ambari-server/src/main/python/ambari-server-windows.py b4d4878d714ef1f18385c685fbab588c6642f976
> ambari-server/src/main/python/ambari-server.py f67d697e344fe6148d2fd1957189f863d2eb8729
> ambari-server/src/main/python/ambari_server/dbConfiguration.py 74bf1945c2b9303816b66353e7c987c40e615eda
> ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 04dbb61eba13a988ee5b2f9b9136dc974488b4a2
> ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 58fa7c4ce3960fb2c4243cd1b4ad12b9f9cec585
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 6b3f3507e1418c16633f8b0f02bc2ed9f47a355b
> ambari-server/src/main/python/ambari_server/serverSetup.py b012fc41114cd1f94336ee1186cb077d912be224
> ambari-server/src/main/python/ambari_server/serverUpgrade.py 1d9735ab34151136ae4d1190259ad2680a341315
> ambari-server/src/main/python/ambari_server/serverUtils.py PRE-CREATION
> ambari-server/src/main/python/ambari_server/setupActions.py 5ca5cce1d6494c3f04399c8706818ac5ab651737
> ambari-server/src/main/python/ambari_server/setupHttps.py PRE-CREATION
> ambari-server/src/main/python/ambari_server/setupSecurity.py 769b5f7aa5c4ac44e638175f34133b5232697d5c
> ambari-server/src/main/python/ambari_server/userInput.py c15d335a50d48430cd7598f31d50a4ded88509ad
> ambari-server/src/main/python/ambari_server_main.py PRE-CREATION
> ambari-server/src/main/python/ambari_windows_service.py PRE-CREATION
> ambari-server/src/main/windows/ambari-server.ps1 9afb341b216f4ca3a99fcb88fb21cf1775385b5c
> ambari-server/src/test/python/TestAmbariServer.py d11e4feedce3fa11099336cb018c9a59e880dd02
>
> Diff: https://reviews.apache.org/r/30243/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> ambari-server setup -> ok
> ambari-server start -> ok
> ambari-server setup-security -> encryption -> start -> ok
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 30243: AMBARI-8317 Refactor the OS-dependent Ambari
Server Windows components - Part 2
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30243/#review69535
-----------------------------------------------------------
Ship it!
Verified Single node installation (ambari-server setup -s, ambari-server start, ambari-server reset).
mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [4.064s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.259s]
[INFO] Ambari Web ........................................ SUCCESS [1:03.315s]
[INFO] Ambari Views ...................................... SUCCESS [2.252s]
[INFO] Ambari Admin View ................................. SUCCESS [10.500s]
[INFO] Ambari Server ..................................... SUCCESS [29:49.863s]
[INFO] Ambari Agent ...................................... SUCCESS [9.550s]
[INFO] Ambari Client ..................................... SUCCESS [0.032s]
[INFO] Ambari Python Client .............................. SUCCESS [0.272s]
[INFO] Ambari Groovy Client .............................. SUCCESS [10.070s]
[INFO] Ambari Shell ...................................... SUCCESS [0.049s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.053s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [7.254s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:38.089s
[INFO] Finished at: Fri Jan 23 21:49:52 PST 2015
[INFO] Final Memory: 52M/487M
[INFO] ------------------------------------------------------------------------
- Jayush Luniya
On Jan. 24, 2015, 3:49 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30243/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2015, 3:49 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
>
>
> Bugs: AMBARI-8317
> https://issues.apache.org/jira/browse/AMBARI-8317
>
>
> Repository: ambari
>
>
> Description
> -------
>
> +Moved LDAP and HTTPS setup routines away from ambari-server.py
> +Merged ambari-server-windows.py into ambari-server.py, leaving out only the Windows service wrapper and the server start routine
>
>
> Diffs
> -----
>
> ambari-server/pom.xml e01375f70beff6464a2a8e30fcb4a5efd0845874
> ambari-server/src/main/assemblies/server-windows.xml 68e3a4e17ff76b7ea4fd8cdf1a5eb4c1672cd505
> ambari-server/src/main/python/ambari-server-windows.py b4d4878d714ef1f18385c685fbab588c6642f976
> ambari-server/src/main/python/ambari-server.py f67d697e344fe6148d2fd1957189f863d2eb8729
> ambari-server/src/main/python/ambari_server/dbConfiguration.py 74bf1945c2b9303816b66353e7c987c40e615eda
> ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 04dbb61eba13a988ee5b2f9b9136dc974488b4a2
> ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 58fa7c4ce3960fb2c4243cd1b4ad12b9f9cec585
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 6b3f3507e1418c16633f8b0f02bc2ed9f47a355b
> ambari-server/src/main/python/ambari_server/serverSetup.py b012fc41114cd1f94336ee1186cb077d912be224
> ambari-server/src/main/python/ambari_server/serverUpgrade.py 1d9735ab34151136ae4d1190259ad2680a341315
> ambari-server/src/main/python/ambari_server/serverUtils.py PRE-CREATION
> ambari-server/src/main/python/ambari_server/setupActions.py 5ca5cce1d6494c3f04399c8706818ac5ab651737
> ambari-server/src/main/python/ambari_server/setupHttps.py PRE-CREATION
> ambari-server/src/main/python/ambari_server/setupSecurity.py 769b5f7aa5c4ac44e638175f34133b5232697d5c
> ambari-server/src/main/python/ambari_server/userInput.py c15d335a50d48430cd7598f31d50a4ded88509ad
> ambari-server/src/main/python/ambari_server_main.py PRE-CREATION
> ambari-server/src/main/python/ambari_windows_service.py PRE-CREATION
> ambari-server/src/main/windows/ambari-server.ps1 9afb341b216f4ca3a99fcb88fb21cf1775385b5c
> ambari-server/src/test/python/TestAmbariServer.py d11e4feedce3fa11099336cb018c9a59e880dd02
>
> Diff: https://reviews.apache.org/r/30243/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> ambari-server setup -> ok
> ambari-server start -> ok
> ambari-server setup-security -> encryption -> start -> ok
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 30243: AMBARI-8317 Refactor the OS-dependent Ambari
Server Windows components - Part 2
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30243/
-----------------------------------------------------------
(Updated Jan. 24, 2015, 3:49 a.m.)
Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
Bugs: AMBARI-8317
https://issues.apache.org/jira/browse/AMBARI-8317
Repository: ambari
Description
-------
+Moved LDAP and HTTPS setup routines away from ambari-server.py
+Merged ambari-server-windows.py into ambari-server.py, leaving out only the Windows service wrapper and the server start routine
Diffs
-----
ambari-server/pom.xml e01375f70beff6464a2a8e30fcb4a5efd0845874
ambari-server/src/main/assemblies/server-windows.xml 68e3a4e17ff76b7ea4fd8cdf1a5eb4c1672cd505
ambari-server/src/main/python/ambari-server-windows.py b4d4878d714ef1f18385c685fbab588c6642f976
ambari-server/src/main/python/ambari-server.py f67d697e344fe6148d2fd1957189f863d2eb8729
ambari-server/src/main/python/ambari_server/dbConfiguration.py 74bf1945c2b9303816b66353e7c987c40e615eda
ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 04dbb61eba13a988ee5b2f9b9136dc974488b4a2
ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 58fa7c4ce3960fb2c4243cd1b4ad12b9f9cec585
ambari-server/src/main/python/ambari_server/serverConfiguration.py 6b3f3507e1418c16633f8b0f02bc2ed9f47a355b
ambari-server/src/main/python/ambari_server/serverSetup.py b012fc41114cd1f94336ee1186cb077d912be224
ambari-server/src/main/python/ambari_server/serverUpgrade.py 1d9735ab34151136ae4d1190259ad2680a341315
ambari-server/src/main/python/ambari_server/serverUtils.py PRE-CREATION
ambari-server/src/main/python/ambari_server/setupActions.py 5ca5cce1d6494c3f04399c8706818ac5ab651737
ambari-server/src/main/python/ambari_server/setupHttps.py PRE-CREATION
ambari-server/src/main/python/ambari_server/setupSecurity.py 769b5f7aa5c4ac44e638175f34133b5232697d5c
ambari-server/src/main/python/ambari_server/userInput.py c15d335a50d48430cd7598f31d50a4ded88509ad
ambari-server/src/main/python/ambari_server_main.py PRE-CREATION
ambari-server/src/main/python/ambari_windows_service.py PRE-CREATION
ambari-server/src/main/windows/ambari-server.ps1 9afb341b216f4ca3a99fcb88fb21cf1775385b5c
ambari-server/src/test/python/TestAmbariServer.py d11e4feedce3fa11099336cb018c9a59e880dd02
Diff: https://reviews.apache.org/r/30243/diff/
Testing (updated)
-------
mvn clean test
ambari-server setup -> ok
ambari-server start -> ok
ambari-server setup-security -> encryption -> start -> ok
Thanks,
Florian Barca