You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/03/14 07:50:39 UTC
Review Request: FLUME-1950. AsyncHBaseSink reconfiguration can fail if
serializer.cleanUp() throws or if hbase client is not shutdown correctly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9921/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Retry close of hbase client if it fails. Also enclose serializer clean up in try-catch
This addresses bug FLUME-1950.
https://issues.apache.org/jira/browse/FLUME-1950
Diffs
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 7020fcd
Diff: https://reviews.apache.org/r/9921/diff/
Testing
-------
All current tests pass.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1950. AsyncHBaseSink reconfiguration can fail if
serializer.cleanUp() throws or if hbase client is not shutdown correctly
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9921/#review17862
-----------------------------------------------------------
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
<https://reviews.apache.org/r/9921/#comment37825>
Can we make the retry configurable? Make this sense?
- Alexander Alten-Lorenz
On March 14, 2013, 6:50 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9921/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 6:50 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Retry close of hbase client if it fails. Also enclose serializer clean up in try-catch
>
>
> This addresses bug FLUME-1950.
> https://issues.apache.org/jira/browse/FLUME-1950
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 7020fcd
>
> Diff: https://reviews.apache.org/r/9921/diff/
>
>
> Testing
> -------
>
> All current tests pass.
>
>
> Thanks,
>
> Hari Shreedharan
>
>