[GitHub] [calcite] hsyuan commented on a change in pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException

[GitBox <gi...@apache.org>]

hsyuan commented on a change in pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException
URL: https://github.com/apache/calcite/pull/1112#discussion_r266653720
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/FilterCorrelateRule.java
 ##########
 @@ -86,8 +86,10 @@ public void onMatch(RelOptRuleCall call) {
         aboveFilters,
         JoinRelType.INNER,
         false,
-        !corr.getJoinType().toJoinType().generatesNullsOnLeft(),
-        !corr.getJoinType().toJoinType().generatesNullsOnRight(),
+        corr.getJoinType().returnsJustFirstInput()
+            || !corr.getJoinType().toJoinType().generatesNullsOnLeft(),
+        !corr.getJoinType().returnsJustFirstInput()
+            && !corr.getJoinType().toJoinType().generatesNullsOnRight(),
 
 Review comment:
   I see what you are trying to do, but it really took me a while to understand. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services