You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/09/28 13:22:32 UTC
[PR] docs: stop listing GROUPS window frames as a fallback [datafusion-comet]
andygrove opened a new pull request, #6303:
URL: https://github.com/apache/datafusion-comet/pull/6303
## Which issue does this PR close?
This is a follow-up to #4836, which I closed as not planned, so there is no issue for it to close.
## Rationale for this change
Spark has no `GROUPS` frame unit. Its grammar only accepts `ROWS` and `RANGE`, and catalyst defines only `RowFrame` and `RangeFrame` through 4.2.0, so no Spark plan can contain a `GROUPS` frame. The window compatibility guide and the roadmap still listed `GROUPS` frames as something Comet falls back on, which suggests there is work left to do when there isn't.
## What changes are included in this PR?
The compatibility guide drops `GROUPS` frames from the window "Falls back to Spark" list. The same bullet noted that Spark rejects `DISTINCT` aggregates over a window, which is true but doesn't belong in a fallback list either, so both facts now sit in one sentence after the list. The roadmap drops `GROUPS` frames from the remaining window work, along with the link definition that pointed at #4836.
## How are these changes tested?
This is a documentation change only. `prettier --check` passes on both files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: stop listing GROUPS window frames as a fallback [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed pull request #6303: docs: stop listing GROUPS window frames as a fallback
URL: https://github.com/apache/datafusion-comet/pull/6303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org