You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/05 09:55:31 UTC
[GitHub] [doris] SaintBacchus opened a new pull request, #10620: [Enhancement][multi-catalog]WIP: Impl parallel for file scanner to improve the scanner performance
SaintBacchus opened a new pull request, #10620:
URL: https://github.com/apache/doris/pull/10620
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Still in dev, may have some dev code
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10620: [Enhancement][multi-catalog]Impl parallel for file scanner to improve the scanner performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10620:
URL: https://github.com/apache/doris/pull/10620#issuecomment-1179477183
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #10620: [Enhancement][multi-catalog]Impl parallel for file scanner to improve the scanner performance
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #10620:
URL: https://github.com/apache/doris/pull/10620#discussion_r916803679
##########
fe/fe-core/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1654,6 +1654,12 @@ public class Config extends ConfigBase {
@ConfField(mutable = false, masterOnly = true)
public static boolean enable_multi_catalog = false; // 1 min
+ @ConfField(mutable = true, masterOnly = true)
Review Comment:
Both `file_scan_node_spilt_size` and `file_scan_node_spilt_num` are NOT `masterOnly` config.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalFileScanNode.java:
##########
@@ -134,6 +135,30 @@ public int numBackends() {
}
}
+ private static class FileSpiltStrategy {
Review Comment:
```suggestion
private static class FileSplitStrategy {
```
And all other `split` typo.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalFileScanNode.java:
##########
@@ -340,6 +380,7 @@ protected void toThrift(TPlanNode planNode) {
@Override
public List<TScanRangeLocations> getScanRangeLocations(long maxScanRangeLength) {
+ LOG.info("There is {} scanRangeLocations for execution.", scanRangeLocations.size());
Review Comment:
```suggestion
LOG.debug("There is {} scanRangeLocations for execution.", scanRangeLocations.size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10620: [Enhancement][multi-catalog]Impl parallel for file scanner to improve the scanner performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10620:
URL: https://github.com/apache/doris/pull/10620#issuecomment-1179477186
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10620: [Enhancement][multi-catalog]Impl parallel for file scanner to improve the scanner performance
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10620:
URL: https://github.com/apache/doris/pull/10620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #10620: [Enhancement][multi-catalog]Impl parallel for file scanner to improve the scanner performance
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #10620:
URL: https://github.com/apache/doris/pull/10620#discussion_r916877906
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalFileScanNode.java:
##########
@@ -311,6 +350,7 @@ private TFileRangeDesc createFileRangeDesc(
// set hdfs params for hdfs file type.
if (scanProvider.getTableFileType() == TFileType.FILE_HDFS) {
THdfsParams tHdfsParams = BrokerUtil.generateHdfsParam(scanProvider.getTableProperties());
+ tHdfsParams.addToHdfsConf(new THdfsConf("dfs.client.read.shortcircuit", "false"));
Review Comment:
Why do we need to disable this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org