You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "jojochuang (via GitHub)" <gi...@apache.org> on 2023/12/02 06:41:38 UTC
[PR] HDDS-9483. ozone freon --server is broken by HDDS-6176. [ozone]
jojochuang opened a new pull request, #5716:
URL: https://github.com/apache/ozone/pull/5716
## What changes were proposed in this pull request?
Specify a default temporary directory for HttpServer2 for 'ozone freon --server' command.
Please describe your PR in detail:
Essentially copy-pasted from HDDS-8253
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9483
## How was this patch tested?
Manually tested on a cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9483. ozone freon --server is broken by HDDS-6176. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5716:
URL: https://github.com/apache/ozone/pull/5716#issuecomment-1837085983
Thanks @jojochuang for the patch.
> Essentially copy-pasted from [HDDS-8253](https://issues.apache.org/jira/browse/HDDS-8253)
Instead of copying, can you please extract to some utility class (e.g. `HddsServerUtil`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9483. ozone freon --server is broken by HDDS-6176. [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #5716:
URL: https://github.com/apache/ozone/pull/5716#issuecomment-1839718422
You can move the code aside or alternatively create in the current working directory for the CLI and avoid having these configs defined for the CLI. It is perfectly fine to create artifacts in the CWD for a binary and cleaning it up at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9483. ozone freon --server is broken by HDDS-6176. [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #5716:
URL: https://github.com/apache/ozone/pull/5716#issuecomment-1847656193
Thanks Attila Ritesh and Swami!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9483. ozone freon --server is broken by HDDS-6176. [ozone]
Posted by "swamirishi (via GitHub)" <gi...@apache.org>.
swamirishi commented on code in PR #5716:
URL: https://github.com/apache/ozone/pull/5716#discussion_r1413835536
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/Freon.java:
##########
@@ -111,9 +118,31 @@ public void stopHttpServer() {
}
}
+ private void setHttpBaseDir()
Review Comment:
this method can be set as a util function in ozone-common module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9483. ozone freon --server is broken by HDDS-6176. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5716:
URL: https://github.com/apache/ozone/pull/5716#issuecomment-1847035798
Thanks @jojochuang for the fix, @kerneltime, @swamirishi for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9483. ozone freon --server is broken by HDDS-6176. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5716:
URL: https://github.com/apache/ozone/pull/5716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org