You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/26 08:09:17 UTC

[GitHub] [spark] Peng-Lei commented on a change in pull request #34096: [SPARK-36841][SQL] Add ansi syntax `set catalog xxx` to change the current catalog

Peng-Lei commented on a change in pull request #34096:
URL: https://github.com/apache/spark/pull/34096#discussion_r716163006



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala
##########
@@ -120,6 +120,7 @@ class CatalogManager(
   def setCurrentCatalog(catalogName: String): Unit = synchronized {
     // `setCurrentCatalog` is noop if it doesn't switch to a different catalog.
     if (currentCatalog.name() != catalogName) {
+      catalog(catalogName)

Review comment:
       Here I just want to check the catalogName is exist and catalog is configed. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org